You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "nastra (via GitHub)" <gi...@apache.org> on 2023/04/06 07:50:54 UTC

[GitHub] [iceberg] nastra commented on a diff in pull request #7286: Core: Fix errorprone warning

nastra commented on code in PR #7286:
URL: https://github.com/apache/iceberg/pull/7286#discussion_r1159413996


##########
core/src/main/java/org/apache/iceberg/inmemory/InMemoryInputFile.java:
##########
@@ -75,7 +75,7 @@ private static class InMemorySeekableInputStream extends SeekableInputStream {
     @Override
     public long getPos() throws IOException {
       checkOpen();
-      return length - delegate.available();
+      return (long) length - delegate.available();

Review Comment:
   I would rather make `length` a long a few lines above



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org