You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ofbiz.apache.org by GitBox <gi...@apache.org> on 2022/01/25 10:53:36 UTC

[GitHub] [ofbiz-framework] mbrohl commented on pull request #482: Improved: Accounting Rates - VIEW permissions (OFBIZ-12530)

mbrohl commented on pull request #482:
URL: https://github.com/apache/ofbiz-framework/pull/482#issuecomment-1021057613


   I think the removal of the blank lines between the elements makes the files less readable and maintanable.
   It would also be better to split between functional changes and code cleanup, would make it possible to only take the functional change and leave the (maybe unwanted) "cleanups".


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org