You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "I3eka (via GitHub)" <gi...@apache.org> on 2026/08/13 15:58:44 UTC
[PR] fix(ai): preserve tool error types in telemetry [superset]
I3eka opened a new pull request, #43124:
URL: https://github.com/apache/superset/pull/43124
# fix(ai): preserve tool error types in telemetry
### SUMMARY
Carry the registry's internal failure class into tool telemetry without exposing exception details to the model or user.
Depends on #42805. Base commit: `0e4a15cca1c5be2b7e68d609a9062f5e51193024`.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Not applicable; backend behavior only.
### TESTING INSTRUCTIONS
`pytest -q tests/unit_tests/ai/test_tools.py tests/unit_tests/ai/test_telemetry.py`
Result: 130 passed.
The changed files also pass the repository pre-commit hooks.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(ai): preserve tool error types in telemetry [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #43124:
URL: https://github.com/apache/superset/pull/43124#issuecomment-5282960521
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(ai): preserve tool error types in telemetry [superset]
Posted by "I3eka (via GitHub)" <gi...@apache.org>.
I3eka closed pull request #43124: fix(ai): preserve tool error types in telemetry
URL: https://github.com/apache/superset/pull/43124
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(ai): preserve tool error types in telemetry [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #43124:
URL: https://github.com/apache/superset/pull/43124#issuecomment-5283043928
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/43124?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `55.16382%` with `2340 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 65.66%. Comparing base ([`2c7adca`](https://app.codecov.io/gh/apache/superset/commit/2c7adcaef8534a0e5ce873e77d9ac74775576545?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8ca2f69`](https://app.codecov.io/gh/apache/superset/commit/8ca2f69b72ca15e87afd8a54de63d5f20532844a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 220 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/superset/pull/43124?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [superset/ai/llm/openai\_compatible.py](https://app.codecov.io/gh/apache/superset/pull/43124?src=pr&el=tree&filepath=superset%2Fai%2Fllm%2Fopenai_compatible.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvYWkvbGxtL29wZW5haV9jb21wYXRpYmxlLnB5) | 0.00% | [219 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/43124?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [superset/ai/llm/anthropic.py](https://app.codecov.io/gh/apache/superset/pull/43124?src=pr&el=tree&filepath=superset%2Fai%2Fllm%2Fanthropic.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvYWkvbGxtL2FudGhyb3BpYy5weQ==) | 0.00% | [216 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/43124?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [superset/ai/page\_context.py](https://app.codecov.io/gh/apache/superset/pull/43124?src=pr&el=tree&filepath=superset%2Fai%2Fpage_context.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvYWkvcGFnZV9jb250ZXh0LnB5) | 13.51% | [159 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/superset/pull/43124?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...tend/src/features/ai/components/ChatChartEmbed.tsx](https://app.codecov.io/gh/apache/superset/pull/43124?src=pr&el=tree&filepath=superset-frontend%2Fsrc%2Ffeatures%2Fai%2Fcomponents%2FChatChartEmbed.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVzL2FpL2NvbXBvbmVudHMvQ2hhdENoYXJ0RW1iZWQudHN4) | 21.50% | [157 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/43124?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...erset-frontend/src/features/ai/hooks/useChatBot.ts](https://app.codecov.io/gh/apache/superset/pull/43124?src=pr&el=tree&filepath=superset-frontend%2Fsrc%2Ffeatures%2Fai%2Fhooks%2FuseChatBot.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVzL2FpL2hvb2tzL3VzZUNoYXRCb3QudHM=) | 73.04% | [138 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/43124?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [superset/ai/eventbus.py](https://app.codecov.io/gh/apache/superset/pull/43124?src=pr&el=tree&filepath=superset%2Fai%2Feventbus.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvYWkvZXZlbnRidXMucHk=) | 0.00% | [134 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/43124?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [superset/ai/mcp/config.py](https://app.codecov.io/gh/apache/superset/pull/43124?src=pr&el=tree&filepath=superset%2Fai%2Fmcp%2Fconfig.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvYWkvbWNwL2NvbmZpZy5weQ==) | 0.00% | [129 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/43124?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [superset/ai/mcp/client.py](https://app.codecov.io/gh/apache/superset/pull/43124?src=pr&el=tree&filepath=superset%2Fai%2Fmcp%2Fclient.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvYWkvbWNwL2NsaWVudC5weQ==) | 0.00% | [110 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/43124?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [superset/ai/runtime/messages.py](https://app.codecov.io/gh/apache/superset/pull/43124?src=pr&el=tree&filepath=superset%2Fai%2Fruntime%2Fmessages.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvYWkvcnVudGltZS9tZXNzYWdlcy5weQ==) | 44.84% | [90 Missing and 17 partials :warning: ](https://app.codecov.io/gh/apache/superset/pull/43124?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [superset/ai/mcp/tools.py](https://app.codecov.io/gh/apache/superset/pull/43124?src=pr&el=tree&filepath=superset%2Fai%2Fmcp%2Ftools.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvYWkvbWNwL3Rvb2xzLnB5) | 0.00% | [96 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/43124?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [26 more](https://app.codecov.io/gh/apache/superset/pull/43124?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #43124 +/- ##
==========================================
- Coverage 65.79% 65.66% -0.13%
==========================================
Files 2842 2906 +64
Lines 162133 169360 +7227
Branches 37159 38408 +1249
==========================================
+ Hits 106675 111214 +4539
- Misses 53393 55907 +2514
- Partials 2065 2239 +174
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/43124/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Ξ | |
|---|---|---|
| [superset-extensions-cli](https://app.codecov.io/gh/apache/superset/pull/43124/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.57% <ΓΈ> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/43124?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(ai): preserve tool error types in telemetry [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #43124:
URL: https://github.com/apache/superset/pull/43124#issuecomment-5283020377
### <span aria-hidden="true">β
</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">π¨</span> Latest commit | 8ca2f69b72ca15e87afd8a54de63d5f20532844a |
|<span aria-hidden="true">π</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6a7de9afbb12ce00096ff0b8 |
|<span aria-hidden="true">π</span> Deploy Preview | [https://deploy-preview-43124--superset-docs-preview.netlify.app](https://deploy-preview-43124--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">π±</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
|<span aria-hidden="true">π€</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#DctBDoMgEEbhu8y6pNSFld6gxxjgJ5qAQyaTRtN4d9m9xff-1FVaN_oQPSgq72kdnSTjeO5s2w-ON2ci1UFV1BkqGkzP4TN6lfObxzHzOyNwifE1JXjvw1yKjwtdNw) |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-43124--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org