You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by so...@apache.org on 2014/07/15 01:01:51 UTC

[04/10] git commit: TS-1475: Coverity 1214713 - close fp

TS-1475: Coverity 1214713 - close fp


Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/93b773d5
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/93b773d5
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/93b773d5

Branch: refs/heads/master
Commit: 93b773d541b535c5c70464268dba8e79aa14fda9
Parents: 84ebfc1
Author: JvD <ja...@cable.comcast.com>
Authored: Mon Jul 14 14:46:33 2014 -0600
Committer: Phil Sorber <so...@apache.org>
Committed: Mon Jul 14 17:01:40 2014 -0600

----------------------------------------------------------------------
 plugins/experimental/url_sig/url_sig.c | 2 ++
 1 file changed, 2 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/trafficserver/blob/93b773d5/plugins/experimental/url_sig/url_sig.c
----------------------------------------------------------------------
diff --git a/plugins/experimental/url_sig/url_sig.c b/plugins/experimental/url_sig/url_sig.c
index be85524..b656755 100644
--- a/plugins/experimental/url_sig/url_sig.c
+++ b/plugins/experimental/url_sig/url_sig.c
@@ -119,6 +119,7 @@ TSRemapNewInstance(int argc, char *argv[], void **ih, char *errbuf, int errbuf_s
     } else {
       snprintf(errbuf, errbuf_size - 1, "[TSRemapNewInstance] - Maximum line (%d) exceeded on line %d.", MAX_KEY_LEN,
                line_no);
+      fclose(file);
       return TS_ERROR;
     }
     if (strncmp(line, "key", 3) == 0) {
@@ -175,6 +176,7 @@ TSRemapNewInstance(int argc, char *argv[], void **ih, char *errbuf, int errbuf_s
     if (cfg->err_url != NULL) {
       snprintf(errbuf, errbuf_size - 1,
                "[TSRemapNewInstance] - Invalid config, err_status == 403, but err_url != NULL");
+      fclose(file);
       return TS_ERROR;
     }
     printf("[url_sig] mapping {%s -> %s} with status %d\n", argv[0], argv[1], cfg->err_status);