You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "aIbrahiim (via GitHub)" <gi...@apache.org> on 2026/05/18 07:55:58 UTC

[PR] Fix PipelineOptions display-data NPE [beam]

aIbrahiim opened a new pull request, #38525:
URL: https://github.com/apache/beam/pull/38525

   **Please** add a meaningful description for your change here
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/actions/workflows/build_wheels.yml/badge.svg?event=schedule&&?branch=master)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/actions/workflows/python_tests.yml/badge.svg?event=schedule&&?branch=master)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/actions/workflows/java_tests.yml/badge.svg?event=schedule&&?branch=master)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/actions/workflows/go_tests.yml/badge.svg?event=schedule&&?branch=master)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix PipelineOptions display-data NPE [beam]

Posted by "aIbrahiim (via GitHub)" <gi...@apache.org>.
aIbrahiim closed pull request #38525: Fix PipelineOptions display-data NPE
URL: https://github.com/apache/beam/pull/38525


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix PipelineOptions display-data NPE [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38525:
URL: https://github.com/apache/beam/pull/38525#issuecomment-4478557509

   Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix PipelineOptions display-data NPE [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38525:
URL: https://github.com/apache/beam/pull/38525#issuecomment-4481825020

   Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment `assign set of reviewers`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix PipelineOptions display-data NPE [beam]

Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on code in PR #38525:
URL: https://github.com/apache/beam/pull/38525#discussion_r3258223025


##########
sdks/java/core/src/main/java/org/apache/beam/sdk/options/PipelineOptionsFactory.java:
##########
@@ -1801,11 +1801,21 @@ static Object deserializeNode(JsonNode node, Method method) throws IOException {
       return null;
     }
 
-    JsonParser parser = new TreeTraversingParser(node, MAPPER);
-    parser.nextToken();
-
+    JavaType javaType = MAPPER.constructType(method.getGenericReturnType());
     JsonDeserializer<Object> jsonDeserializer = getDeserializerForMethod(method);
-    return jsonDeserializer.deserialize(parser, DESERIALIZATION_CONTEXT.copy());
+    if (jsonDeserializer == null) {
+      return MAPPER.treeToValue(node, javaType);
+    }
+
+    try {
+      JsonParser parser = new TreeTraversingParser(node, MAPPER);
+      parser.nextToken();
+      return jsonDeserializer.deserialize(parser, DESERIALIZATION_CONTEXT.copy());
+    } catch (NullPointerException e) {
+      // Jackson 2.18+ can yield a non-null contextual JsonDeserializer that still NPEs for some
+      // pipeline option shapes during display-data serialization (Flink ValidatesRunner Kafka).
+      return MAPPER.treeToValue(node, javaType);
+    }

Review Comment:
   ![medium](https://www.gstatic.com/codereviewagent/medium-priority.svg)
   
   The `javaType` is only used in the fallback paths (when `jsonDeserializer` is null or when an NPE occurs). Moving its construction into those specific blocks avoids unnecessary overhead in the common successful path where a deserializer is available and functional.
   
   ```java
       JsonDeserializer<Object> jsonDeserializer = getDeserializerForMethod(method);
       if (jsonDeserializer == null) {
         JavaType javaType = MAPPER.constructType(method.getGenericReturnType());
         return MAPPER.treeToValue(node, javaType);
       }
   
       try {
         JsonParser parser = new TreeTraversingParser(node, MAPPER);
         parser.nextToken();
         return jsonDeserializer.deserialize(parser, DESERIALIZATION_CONTEXT.copy());
       } catch (NullPointerException e) {
         // Jackson 2.18+ can yield a non-null contextual JsonDeserializer that still NPEs for some
         // pipeline option shapes during display-data serialization (Flink ValidatesRunner Kafka).
         JavaType javaType = MAPPER.constructType(method.getGenericReturnType());
         return MAPPER.treeToValue(node, javaType);
       }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix PipelineOptions display-data NPE [beam]

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #38525:
URL: https://github.com/apache/beam/pull/38525#issuecomment-4481809889

   R: @shunping (who is taking a look as well: #38531)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix PipelineOptions display-data NPE [beam]

Posted by "shunping (via GitHub)" <gi...@apache.org>.
shunping commented on PR #38525:
URL: https://github.com/apache/beam/pull/38525#issuecomment-4488362395

   Rerunning the test on master: https://github.com/apache/beam/actions/runs/26096934872/job/76750721630
   
   The last run failed because of maven hiccup.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix PipelineOptions display-data NPE [beam]

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #38525:
URL: https://github.com/apache/beam/pull/38525#discussion_r3260538027


##########
sdks/java/core/src/main/java/org/apache/beam/sdk/options/PipelineOptionsFactory.java:
##########
@@ -1801,11 +1801,22 @@ static Object deserializeNode(JsonNode node, Method method) throws IOException {
       return null;
     }
 
-    JsonParser parser = new TreeTraversingParser(node, MAPPER);
-    parser.nextToken();
-
     JsonDeserializer<Object> jsonDeserializer = getDeserializerForMethod(method);
-    return jsonDeserializer.deserialize(parser, DESERIALIZATION_CONTEXT.copy());
+    if (jsonDeserializer == null) {
+      JavaType javaType = MAPPER.constructType(method.getGenericReturnType());
+      return MAPPER.treeToValue(node, javaType);
+    }
+
+    try {
+      JsonParser parser = new TreeTraversingParser(node, MAPPER);
+      parser.nextToken();
+      return jsonDeserializer.deserialize(parser, DESERIALIZATION_CONTEXT.copy());
+    } catch (NullPointerException e) {

Review Comment:
   catch an NPE is almost always an anti-pattern. Let me check what happens caused NPE here, and stack trace?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix PipelineOptions display-data NPE [beam]

Posted by "aIbrahiim (via GitHub)" <gi...@apache.org>.
aIbrahiim commented on code in PR #38525:
URL: https://github.com/apache/beam/pull/38525#discussion_r3261147848


##########
sdks/java/core/src/main/java/org/apache/beam/sdk/options/PipelineOptionsFactory.java:
##########
@@ -1801,11 +1801,22 @@ static Object deserializeNode(JsonNode node, Method method) throws IOException {
       return null;
     }
 
-    JsonParser parser = new TreeTraversingParser(node, MAPPER);
-    parser.nextToken();
-
     JsonDeserializer<Object> jsonDeserializer = getDeserializerForMethod(method);
-    return jsonDeserializer.deserialize(parser, DESERIALIZATION_CONTEXT.copy());
+    if (jsonDeserializer == null) {
+      JavaType javaType = MAPPER.constructType(method.getGenericReturnType());
+      return MAPPER.treeToValue(node, javaType);
+    }
+
+    try {
+      JsonParser parser = new TreeTraversingParser(node, MAPPER);
+      parser.nextToken();
+      return jsonDeserializer.deserialize(parser, DESERIALIZATION_CONTEXT.copy());
+    } catch (NullPointerException e) {

Review Comment:
   ahh right it is not a long term fix, i refactored it and her'es the stack trace:
   
   java.lang.IllegalArgumentException: Error while populating display data for component
     'org.apache.beam.sdk.options.ProxyInvocationHandler$PipelineOptionsDisplayData': null
     at PipelineOptionsTranslation.toProto(...)
     at FlinkJobInvoker.createJobInvocation(...)
     ...
   Caused by: java.lang.NullPointerException
     at PipelineOptionsFactory.deserializeNode(PipelineOptionsFactory.java:1813)
     at ProxyInvocationHandler.getValueFromJson(...)
     at ProxyInvocationHandler$PipelineOptionsDisplayData.populateDisplayData(...:446)
     at DisplayData.from(...)
     at ProxyInvocationHandler$Serializer.serialize(...) 
   
   Caused by: java.lang.NullPointerException
     at org.apache.beam.sdk.options.PipelineOptionsFactory.deserializeNode(...)
     at org.apache.beam.sdk.options.ProxyInvocationHandler.getValueFromJson(...)
     at org.apache.beam.sdk.options.ProxyInvocationHandler$PipelineOptionsDisplayData.populateDisplayData(...:446)
     at org.apache.beam.sdk.transforms.display.DisplayData.from(...)
     at org.apache.beam.sdk.options.ProxyInvocationHandler$Serializer.serialize(...)
     at org.apache.beam.sdk.util.construction.PipelineOptionsTranslation.toProto(...)
     at org.apache.beam.runners.flink.FlinkJobInvoker.createJobInvocation(...)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix PipelineOptions display-data NPE [beam]

Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on PR #38525:
URL: https://github.com/apache/beam/pull/38525#issuecomment-4476848946

   ## Summary of Changes
   
   Hello, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
   
   This pull request addresses a NullPointerException occurring during PipelineOptions display-data serialization, specifically observed with newer Jackson versions. It introduces a defensive fallback mechanism in the deserialization logic to ensure stability when contextual deserializers fail, and includes a regression test to prevent future occurrences.
   
   ### Highlights
   
   * **NPE Fix in PipelineOptionsFactory**: Added robust error handling in deserializeNode to catch NullPointerExceptions during JSON deserialization, falling back to standard Jackson tree-to-value conversion.
   * **Improved Deserializer Logic**: Updated computeDeserializerForMethod to ensure typeDeserializer and jsonDeserializer are both non-null before wrapping, preventing potential issues.
   * **Regression Testing**: Added a new test case in PipelineOptionsFactoryTest to verify that display-data population works correctly after a JSON round-trip for polymorphic options.
   
   <details>
   <summary><b>New Features</b></summary>
   
   🧠 You can now enable **Memory** (public preview) to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.**
   </details>
   
   <details>
   <summary><b>Using Gemini Code Assist</b></summary>
   <br>
   
   The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips.
   
   <b>Invoking Gemini</b>
   
   You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page.
   
   Feature | Command | Description
   --- | --- | ---
   Code Review | `/gemini review` | Performs a code review for the current pull request in its current state.
   Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state.
   Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments.
   Help | `/gemini help` | Displays a list of available commands.
   
   <b>Customization</b>
   
   To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github).
   
   <b>Limitations & Feedback</b>
   
   Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG).
   </details>
   
   
   [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org