You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@griffin.apache.org by GitBox <gi...@apache.org> on 2019/03/06 16:52:05 UTC

[GitHub] [griffin] chemikadze commented on a change in pull request #484: GRIFFIN-232 - add support pluggable predicates

chemikadze commented on a change in pull request #484: GRIFFIN-232 - add support pluggable predicates
URL: https://github.com/apache/griffin/pull/484#discussion_r263032819
 
 

 ##########
 File path: service/pom.xml
 ##########
 @@ -291,8 +291,9 @@ under the License.
                     </execution>
                 </executions>
                 <configuration>
+                    <classifier>exec</classifier>
                     <fork>true</fork>
-                    <layout>JAR</layout>
+                    <layout>ZIP</layout>
 
 Review comment:
   will this change be required, if we'll do something like that:
   ```
   java -cp griffin-service.jar -Dloader.path="/path/to/lib/plugin.jar" org.springframework.boot.loader.PropertiesLauncher
   ```
   ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services