You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by gu...@apache.org on 2018/12/31 13:32:16 UTC
lucene-solr:branch_7x: SOLR-13086 improve error message in
DocumentObjectBinder
Repository: lucene-solr
Updated Branches:
refs/heads/branch_7x c108783cd -> 2ccb50591
SOLR-13086 improve error message in DocumentObjectBinder
Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/2ccb5059
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/2ccb5059
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/2ccb5059
Branch: refs/heads/branch_7x
Commit: 2ccb505912f5ee1818112e27518154b606b7512e
Parents: c108783
Author: Gus Heck <gu...@apache.org>
Authored: Mon Dec 31 08:31:12 2018 -0500
Committer: Gus Heck <gu...@apache.org>
Committed: Mon Dec 31 08:31:12 2018 -0500
----------------------------------------------------------------------
solr/CHANGES.txt | 3 +++
.../org/apache/solr/client/solrj/beans/DocumentObjectBinder.java | 3 ++-
2 files changed, 5 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/2ccb5059/solr/CHANGES.txt
----------------------------------------------------------------------
diff --git a/solr/CHANGES.txt b/solr/CHANGES.txt
index 554a464..ad6bd48 100644
--- a/solr/CHANGES.txt
+++ b/solr/CHANGES.txt
@@ -107,6 +107,9 @@ Other Changes
* SOLR-12727: Upgrade ZooKeeper dependency to 3.4.13 (Kevin Risden, Erick Erickson)
+* SOLR-13086: Improve the error message reported by DocumentObjectBinder when a setter is not found (Gus Heck)
+
+
================== 7.6.0 ==================
Consult the LUCENE_CHANGES.txt file for additional, low level, changes in this release.
http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/2ccb5059/solr/solrj/src/java/org/apache/solr/client/solrj/beans/DocumentObjectBinder.java
----------------------------------------------------------------------
diff --git a/solr/solrj/src/java/org/apache/solr/client/solrj/beans/DocumentObjectBinder.java b/solr/solrj/src/java/org/apache/solr/client/solrj/beans/DocumentObjectBinder.java
index e2e65bb..2e78093 100644
--- a/solr/solrj/src/java/org/apache/solr/client/solrj/beans/DocumentObjectBinder.java
+++ b/solr/solrj/src/java/org/apache/solr/client/solrj/beans/DocumentObjectBinder.java
@@ -232,7 +232,8 @@ public class DocumentObjectBinder {
} else {
Class[] params = setter.getParameterTypes();
if (params.length != 1) {
- throw new BindingException("Invalid setter method. Must have one and only one parameter");
+ throw new BindingException("Invalid setter method (" + setter +
+ "). A setter must have one and only one parameter but we found " + params.length + " parameters.");
}
type = params[0];
}