You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/06 08:20:31 UTC
[GitHub] [spark] ivoson opened a new pull request #35405: [SPARK-38105][SQL] Use error classes in the parsing errors of joins
ivoson opened a new pull request #35405:
URL: https://github.com/apache/spark/pull/35405
### What changes were proposed in this pull request?
Migrate the following errors in QueryParsingErrors onto use error classes:
1. joinCriteriaUnimplementedError => INTERNAL_ERROR (should never happen, introduced by improving exhaustivity in [PR)](https://github.com/apache/spark/pull/30455)
2. naturalCrossJoinUnsupportedError => UNSUPPORTED_FEATURE
### Why are the changes needed?
Porting join parsing errors to new error framework.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
UT added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ivoson commented on pull request #35405: [SPARK-38105][SQL] Use error classes in the parsing errors of joins
Posted by GitBox <gi...@apache.org>.
ivoson commented on pull request #35405:
URL: https://github.com/apache/spark/pull/35405#issuecomment-1030808550
> > INTERNAL_ERROR (should never happen, introduced by improving exhaustivity in #30455)
>
> Let's throw `IllegalStateException` since it is not visible to end users (as we have already implemented that in #35302). We should use error classes only for errors that can be propagated to user space.
Thanks @MaxGekk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #35405: [SPARK-38105][SQL] Use error classes in the parsing errors of joins
Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #35405:
URL: https://github.com/apache/spark/pull/35405
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #35405: [SPARK-38105][SQL] Use error classes in the parsing errors of joins
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #35405:
URL: https://github.com/apache/spark/pull/35405#issuecomment-1030777783
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #35405: [SPARK-38105][SQL] Use error classes in the parsing errors of joins
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #35405:
URL: https://github.com/apache/spark/pull/35405#issuecomment-1030886056
+1, LGTM. Merging to master.
Thank you, @ivoson .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org