You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Tony Kamenick (JIRA)" <ji...@apache.org> on 2010/06/28 21:52:50 UTC
[jira] Created: (THRIFT-811) http_client_transport.rb: allow custom
http headers
http_client_transport.rb: allow custom http headers
---------------------------------------------------
Key: THRIFT-811
URL: https://issues.apache.org/jira/browse/THRIFT-811
Project: Thrift
Issue Type: Improvement
Components: Library (Ruby)
Reporter: Tony Kamenick
Priority: Minor
The http headers in http_client_transport.rb were defined locally in flush, so the user could not easily specify custom headers. I made headers an instance variable and created an add_headers() method that accepts a hash of headers to send to the server. I included a test that fails before the patch and succeeds afterward. My editor also moved some trailing white space that was hanging out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-811) http_client_transport.rb: allow custom
http headers
Posted by "Michael Stockton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Stockton updated THRIFT-811:
------------------------------------
Affects Version/s: 0.4
> http_client_transport.rb: allow custom http headers
> ---------------------------------------------------
>
> Key: THRIFT-811
> URL: https://issues.apache.org/jira/browse/THRIFT-811
> Project: Thrift
> Issue Type: Improvement
> Components: Library (Ruby)
> Affects Versions: 0.4
> Reporter: Tony Kamenick
> Priority: Minor
> Attachments: custom_http_headers.patch
>
>
> The http headers in http_client_transport.rb were defined locally in flush, so the user could not easily specify custom headers. I made headers an instance variable and created an add_headers() method that accepts a hash of headers to send to the server. I included a test that fails before the patch and succeeds afterward. My editor also moved some trailing white space that was hanging out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (THRIFT-811) http_client_transport.rb: allow custom
http headers
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury closed THRIFT-811.
--------------------------------
Assignee: Tony Kamenick
Fix Version/s: 0.4
Resolution: Fixed
I just committed this. Thanks for the patch, Tony!
> http_client_transport.rb: allow custom http headers
> ---------------------------------------------------
>
> Key: THRIFT-811
> URL: https://issues.apache.org/jira/browse/THRIFT-811
> Project: Thrift
> Issue Type: Improvement
> Components: Library (Ruby)
> Affects Versions: 0.4
> Reporter: Tony Kamenick
> Assignee: Tony Kamenick
> Priority: Minor
> Fix For: 0.4
>
> Attachments: custom_http_headers.patch
>
>
> The http headers in http_client_transport.rb were defined locally in flush, so the user could not easily specify custom headers. I made headers an instance variable and created an add_headers() method that accepts a hash of headers to send to the server. I included a test that fails before the patch and succeeds afterward. My editor also moved some trailing white space that was hanging out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-811) http_client_transport.rb: allow custom
http headers
Posted by "Tony Kamenick (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tony Kamenick updated THRIFT-811:
---------------------------------
Attachment: custom_http_headers.patch
Allows setting of custom http headers in http_client_transport.rb
> http_client_transport.rb: allow custom http headers
> ---------------------------------------------------
>
> Key: THRIFT-811
> URL: https://issues.apache.org/jira/browse/THRIFT-811
> Project: Thrift
> Issue Type: Improvement
> Components: Library (Ruby)
> Reporter: Tony Kamenick
> Priority: Minor
> Attachments: custom_http_headers.patch
>
>
> The http headers in http_client_transport.rb were defined locally in flush, so the user could not easily specify custom headers. I made headers an instance variable and created an add_headers() method that accepts a hash of headers to send to the server. I included a test that fails before the patch and succeeds afterward. My editor also moved some trailing white space that was hanging out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.