You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/10/09 01:41:29 UTC
[GitHub] [dolphinscheduler] wushanru opened a new pull request, #12265: [Hotfix][Docs] Fix workflow definition description
wushanru opened a new pull request, #12265:
URL: https://github.com/apache/dolphinscheduler/pull/12265
Fix workflow definition description that in official website:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] wushanru commented on pull request #12265: [Docs] Change the process in all files to workflow
Posted by GitBox <gi...@apache.org>.
wushanru commented on PR #12265:
URL: https://github.com/apache/dolphinscheduler/pull/12265#issuecomment-1272810381
> > > > @SbloodyS i'm not found dead link . can you re-run?
> > >
> > >
> > > There are some conflicts needs to be resolved. @wushanru
> >
> >
> > I don't quite understand what you mean. What should I do @SbloodyS
>
> > > > @SbloodyS i'm not found dead link . can you re-run?
> > >
> > >
> > > There are some conflicts needs to be resolved. @wushanru
> >
> >
> > I don't quite understand what you mean. What should I do @SbloodyS
>
> @wushanru As you could see below, your branch has conflicts with the dev branch, therefore, you need to use `git rebase` command to resolve the conflicts. 
I have resolved the conflict. Please take a look. Thank you @SbloodyS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on pull request #12265: [Docs] Change the process in all files to workflow
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #12265:
URL: https://github.com/apache/dolphinscheduler/pull/12265#issuecomment-1272751979
> > > @SbloodyS i'm not found dead link . can you re-run?
> >
> >
> > There are some conflicts needs to be resolved. @wushanru
>
> I don't quite understand what you mean. What should I do @SbloodyS
> > > @SbloodyS i'm not found dead link . can you re-run?
> >
> >
> > There are some conflicts needs to be resolved. @wushanru
>
> I don't quite understand what you mean. What should I do @SbloodyS
@wushanru As you could see below, your branch has conflicts with the dev branch, therefore, you need to use `git rebase` command to resolve the conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] wushanru commented on pull request #12265: [Docs] Change the process in all files to workflow
Posted by GitBox <gi...@apache.org>.
wushanru commented on PR #12265:
URL: https://github.com/apache/dolphinscheduler/pull/12265#issuecomment-1272833304
@
> > > > @SbloodyS i'm not found dead link . can you re-run?
> > >
> > >
> > > There are some conflicts needs to be resolved. @wushanru
> >
> >
> > I don't quite understand what you mean. What should I do @SbloodyS
>
> > > > @SbloodyS i'm not found dead link . can you re-run?
> > >
> > >
> > > There are some conflicts needs to be resolved. @wushanru
> >
> >
> > I don't quite understand what you mean. What should I do @SbloodyS
>
> @wushanru As you could see below, your branch has conflicts with the dev branch, therefore, you need to use `git rebase` command to resolve the conflicts. 
I haven't handled this open source code conflict. Can you tell me the detailed operation steps? thank! @SbloodyS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on pull request #12265: [Docs] Change the process in all files to workflow
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on PR #12265:
URL: https://github.com/apache/dolphinscheduler/pull/12265#issuecomment-1272702337
> @SbloodyS i'm not found dead link . can you re-run?
There are some conflicts needs to be resolved. @wushanru
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] wushanru commented on pull request #12265: [Docs] Change the process in all files to workflow
Posted by GitBox <gi...@apache.org>.
wushanru commented on PR #12265:
URL: https://github.com/apache/dolphinscheduler/pull/12265#issuecomment-1272720173
> > @SbloodyS i'm not found dead link . can you re-run?
>
> There are some conflicts needs to be resolved. @wushanru
I don't quite understand what you mean. What should I do。@SbloodyS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] fuchanghai commented on pull request #12265: [Docs] Change the process in all files to workflow
Posted by GitBox <gi...@apache.org>.
fuchanghai commented on PR #12265:
URL: https://github.com/apache/dolphinscheduler/pull/12265#issuecomment-1272701074
@SbloodyS i'm not found dead link . can you re-run?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #12265: [Hotfix][Docs] Fix workflow definition description
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on code in PR #12265:
URL: https://github.com/apache/dolphinscheduler/pull/12265#discussion_r990717812
##########
docs/docs/en/guide/project/project-list.md:
##########
@@ -2,11 +2,11 @@
This page describes details regarding Project screen in Apache DolphinScheduler. Here, you will see all the functions which can be handled in this screen. The following table explains commonly used terms in Apache DolphinScheduler:
-| Glossary | description |
+| Glossary | description |
|---------------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| DAG | Tasks in a workflow are assembled in form of Directed Acyclic Graph (DAG). A topological traversal is performed from nodes with zero degrees of entry until there are no subsequent nodes. |
| Workflow Definition | Visualization formed by dragging task nodes and establishing task node associations (DAG). |
-| Workflow Instance | Instantiation of the workflow definition, which can be generated by manual start or scheduled scheduling. Each time the process definition runs, a workflow instance is generated. |
+| Workflow Instance | Instantiation of the workflow definition, which can be generated by manual start or scheduled scheduling. Each time the workflow definition runs, a workflow instance is generated. |
| Workflow Relation | Shows dynamic status of all the workflows in a project. |
| Task | Task is a discrete action in a Workflow. Apache DolphinScheduler supports SHELL, SQL, SUB_PROCESS (sub-process), PROCEDURE, MR, SPARK, PYTHON, DEPENDENT ( depends), and plans to support dynamic plug-in expansion, (SUB_PROCESS). It is also a separate process definition that can be started and executed separately. |
| Task Instance | Instantiation of the task node in the process definition, which identifies the specific task execution status. |
Review Comment:
Can you modify the process definition of the whole file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] wushanru closed pull request #12265: [Docs] Change the process in all files to workflow
Posted by GitBox <gi...@apache.org>.
wushanru closed pull request #12265: [Docs] Change the process in all files to workflow
URL: https://github.com/apache/dolphinscheduler/pull/12265
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on pull request #12265: [Hotfix][Docs] fix modify the process definition in the whole file
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #12265:
URL: https://github.com/apache/dolphinscheduler/pull/12265#issuecomment-1272468673
>  @wushanru There are still some changes that need to be made。plz global search
+1, we'd better keep the docs consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] wushanru commented on pull request #12265: [Docs] Change the process in all files to workflow
Posted by GitBox <gi...@apache.org>.
wushanru commented on PR #12265:
URL: https://github.com/apache/dolphinscheduler/pull/12265#issuecomment-1272719082
> > @SbloodyS i'm not found dead link . can you re-run?
>
> There are some conflicts needs to be resolved. @wushanru
I don't quite understand what you mean. What should I do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on pull request #12265: [Docs] Change the process in all files to workflow
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #12265:
URL: https://github.com/apache/dolphinscheduler/pull/12265#issuecomment-1272943864
> > > @wushanru file named glossary had changed ,above conflict with you fix code
> >
> >
> > @fuchanghai My first PR, this conflict is also the first time to resolve, I don't quite understand your meaning, please tell me the specific steps, thank you！
>
> @wushanru Looks like you didn't correctly rebase your code and pushed the dev branch instead. Please refer to this link for instructions: https://github.com/sevntu-checkstyle/sevntu.checkstyle/wiki/Development-workflow-with-Git:-Fork,-Branching,-Commits,-and-Pull-Request
BTW, the `master` branch in the above article is called `dev` branch in DolphinScheduler repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] fuchanghai commented on pull request #12265: [Docs] Change the process in all files to workflow
Posted by GitBox <gi...@apache.org>.
fuchanghai commented on PR #12265:
URL: https://github.com/apache/dolphinscheduler/pull/12265#issuecomment-1272843939
@wushanru file named glossary had changed ,above conflict with you fix code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #12265: [Docs] Change the process in all files to workflow
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on code in PR #12265:
URL: https://github.com/apache/dolphinscheduler/pull/12265#discussion_r990754928
##########
docs/docs/en/contribute/join/become-a-committer.md:
##########
@@ -82,7 +82,7 @@ receive a follow-up message with the next steps for
establishing you as a committer.
```
-## Invitation acceptance process
+## Invitation acceptance workflow
Review Comment:
Same here.
##########
docs/docs/en/contribute/join/become-a-committer.md:
##########
@@ -46,7 +46,7 @@ rather than unnecessary constraints.
Being a committer enables you to more easily make
changes without needing to go through the patch
-submission process.
+submission workflow.
Review Comment:
This should not be modified.
##########
docs/docs/en/contribute/join/become-a-committer.md:
##########
@@ -16,14 +16,14 @@ Community involvement: Committers should have a constructive and friendly attitu
## Nominate new committer
-In Dolphinscheduler, **new committer nomination** could only be officially started by existing PMC members. If a new committer feels that he/she is qualified, he/she should contact any existing PMC member and discuss. If this is agreed among some members of the PMC, the process will kick off.
+In Dolphinscheduler, **new committer nomination** could only be officially started by existing PMC members. If a new committer feels that he/she is qualified, he/she should contact any existing PMC member and discuss. If this is agreed among some members of the PMC, the workflow will kick off.
Review Comment:
Same here.
##########
docs/docs/en/contribute/join/become-a-committer.md:
##########
@@ -150,7 +150,7 @@ The V.P. and chair of the PMC is the secretary, who is responsible for initializ
In most cases, a new PMC member is nominated from the committer team. But it is also possible to become a PMC member directly, so long as the PMC agrees to the nomination and is confident that the candidate is ready. For instance, this can be demonstrated by the fact that he/she has been an Apache member, an Apache officer, or a PMC member of another project.
-The new PMC voting process should also follow the `[DISCUSS]`, `[VOTE]` and `[RESULT][VOTE]` procedures using a private mail list, just like the voting process for new committers.
+The new PMC voting workflow should also follow the `[DISCUSS]`, `[VOTE]` and `[RESULT][VOTE]` procedures using a private mail list, just like the voting workflow for new committers.
Review Comment:
Same here.
##########
docs/docs/en/contribute/join/become-a-committer.md:
##########
@@ -133,8 +133,8 @@ As a committer, you could
2. Create and push codes to the new branch in the Apache repo.
3. Prepare a new release. Remember to confirm with the committer team before you prepare, because that it is the right time to create the release.
-The PMC hopes that the new committer will take part in the release process as well as release voting, even though their vote will be regarded as `+1 no binding`.
-Being familiar with the release process is key to being promoted to the role of PMC member.
+The PMC hopes that the new committer will take part in the release workflow as well as release voting, even though their vote will be regarded as `+1 no binding`.
+Being familiar with the release workflow is key to being promoted to the role of PMC member.
Review Comment:
Same here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] wushanru commented on pull request #12265: [Docs] Change the process in all files to workflow
Posted by GitBox <gi...@apache.org>.
wushanru commented on PR #12265:
URL: https://github.com/apache/dolphinscheduler/pull/12265#issuecomment-1272849091
> @wushanru file named glossary had changed ,above conflict with you fix code
@fuchanghai My first PR, this conflict is also the first time to resolve, I don't quite understand your meaning, please tell me the specific steps, thank you！
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] wushanru commented on pull request #12265: [Docs] Change the process in all files to workflow
Posted by GitBox <gi...@apache.org>.
wushanru commented on PR #12265:
URL: https://github.com/apache/dolphinscheduler/pull/12265#issuecomment-1272720516
> > @SbloodyS i'm not found dead link . can you re-run?
>
> There are some conflicts needs to be resolved. @wushanru
I don't quite understand what you mean. What should I do @SbloodyS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on pull request #12265: [Docs] Change the process in all files to workflow
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #12265:
URL: https://github.com/apache/dolphinscheduler/pull/12265#issuecomment-1272942858
> > @wushanru file named glossary had changed ,above conflict with you fix code
>
> @fuchanghai My first PR, this conflict is also the first time to resolve, I don't quite understand your meaning, please tell me the specific steps, thank you！
@wushanru Looks like you didn't correctly rebase your code and pushed the dev branch instead. Please refer to this link for instructions: https://github.com/sevntu-checkstyle/sevntu.checkstyle/wiki/Development-workflow-with-Git:-Fork,-Branching,-Commits,-and-Pull-Request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on pull request #12265: [Hotfix][Docs] Fix workflow definition description
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #12265:
URL: https://github.com/apache/dolphinscheduler/pull/12265#issuecomment-1272429795
@wushanru Thanks for submitting this PR. There are multiple places where we need to replace process with definition, could u plz also fix them in this PR? Just simply ctr/cmd + shift + r in your IDE. BTW, instead of giving a WeChat screenshot, could u plz write some text description when submitting PR? Thanks again : )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] fuchanghai commented on pull request #12265: [Hotfix][Docs] fix modify the process definition in the whole file
Posted by GitBox <gi...@apache.org>.
fuchanghai commented on PR #12265:
URL: https://github.com/apache/dolphinscheduler/pull/12265#issuecomment-1272446957
@wushanru There are still some changes that need to be made。plz global search
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] wushanru commented on pull request #12265: [Docs] Change the process in all files to workflow
Posted by GitBox <gi...@apache.org>.
wushanru commented on PR #12265:
URL: https://github.com/apache/dolphinscheduler/pull/12265#issuecomment-1272846341
> @wushanru file named glossary had changed ,above conflict with you fix code
@
> @wushanru file named glossary had changed ,above conflict with you fix code
@fuchanghai My first PR, this conflict is also the first time to resolve, I don't quite understand your meaning, please tell me the specific steps, thank you！
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org