You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/02/25 13:16:32 UTC

[GitHub] [superset] zhaoyongjie commented on a change in pull request #18945: feat(legacy-preset-chart-deckgl): Add ,.1f and ,.2f value formats to deckgl charts

zhaoyongjie commented on a change in pull request #18945:
URL: https://github.com/apache/superset/pull/18945#discussion_r814758444



##########
File path: superset-frontend/plugins/legacy-preset-chart-deckgl/src/utilities/controls.jsx
##########
@@ -37,6 +37,8 @@ export const D3_FORMAT_OPTIONS = [
   [',.1%', ',.1% (12345.432 => 1,234,543.2%)'],
   ['.3%', '.3% (12345.432 => 1234543.200%)'],
   ['.4r', '.4r (12345.432 => 12350)'],
+  [',.1f', ',.1f (12345.432 => 12,345.4)'],

Review comment:
       I remember that users can enter d3format manually. Why do we need to create a format in deckgl that is not consistent with all other charts?
   
   <img width="1115" alt="image" src="https://user-images.githubusercontent.com/2016594/155721403-170e5cc7-b1a9-4c9f-9714-b9896291b13e.png">
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org