[GitHub] [arrow-ballista] yahoNanJing commented on a diff in pull request #738: [feature] support shuffle read with retry when facing IO error.

["yahoNanJing (via GitHub)" <gi...@apache.org>]

yahoNanJing commented on code in PR #738:
URL: https://github.com/apache/arrow-ballista/pull/738#discussion_r1162258404


##########
ballista/core/src/client.rs:
##########
@@ -117,32 +120,69 @@ impl BallistaClient {
             .encode(&mut buf)
             .map_err(|e| BallistaError::GrpcActionError(format!("{e:?}")))?;
 
-        let request = tonic::Request::new(Ticket { ticket: buf.into() });
-
-        let mut stream = self
-            .flight_client
-            .do_get(request)
-            .await
-            .map_err(|e| BallistaError::GrpcActionError(format!("{e:?}")))?
-            .into_inner();
+        for i in 0..IO_RETRIES_TIMES {

Review Comment:
   Maybe better to extract the retry logic into a function to get the `FlightData`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org