[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6693: make resizeTimeMs metric as a Gauge instead of a Meter

[GitBox <gi...@apache.org>]

mqliang commented on a change in pull request #6693:
URL: https://github.com/apache/incubator-pinot/pull/6693#discussion_r596297302



##########
File path: pinot-common/src/main/java/org/apache/pinot/common/metrics/BrokerMeter.java
##########
@@ -64,8 +64,7 @@
   ENTRIES_SCANNED_IN_FILTER("documents", false),
   ENTRIES_SCANNED_POST_FILTER("documents", false),
 
-  NUM_RESIZES("resizes", false),
-  RESIZE_TIME_MS("resizeTimeMs", false),
+  NUM_RESIZES("numResizes", false),

Review comment:
       @siddharthteotia I also change the unit of BrokerMeter from "resizes" to "numResizes" to keep consistence with ServerMeter. Let me know if I need change back.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org