You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficcontrol.apache.org by de...@apache.org on 2017/04/20 19:21:57 UTC
[4/4] incubator-trafficcontrol git commit: fix password passing and
remove gzip compression
fix password passing and remove gzip compression
Project: http://git-wip-us.apache.org/repos/asf/incubator-trafficcontrol/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-trafficcontrol/commit/4e749f0d
Tree: http://git-wip-us.apache.org/repos/asf/incubator-trafficcontrol/tree/4e749f0d
Diff: http://git-wip-us.apache.org/repos/asf/incubator-trafficcontrol/diff/4e749f0d
Branch: refs/heads/master
Commit: 4e749f0d33a0541b22fbe558ab29bb4e91c7d720
Parents: dbd68c6
Author: Derek Gelinas <de...@cable.comcast.com>
Authored: Thu Apr 20 14:54:37 2017 -0400
Committer: Dewayne Richardson <de...@apache.org>
Committed: Thu Apr 20 13:21:41 2017 -0600
----------------------------------------------------------------------
traffic_ops/app/lib/UI/GenDbDump.pm | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-trafficcontrol/blob/4e749f0d/traffic_ops/app/lib/UI/GenDbDump.pm
----------------------------------------------------------------------
diff --git a/traffic_ops/app/lib/UI/GenDbDump.pm b/traffic_ops/app/lib/UI/GenDbDump.pm
index 5bc6ce9..6d2b14a 100644
--- a/traffic_ops/app/lib/UI/GenDbDump.pm
+++ b/traffic_ops/app/lib/UI/GenDbDump.pm
@@ -33,7 +33,7 @@ sub dbdump {
my $db_user = $Schema::user;
my $db_pass = $Schema::pass;
- my $ok = open my $fh, '-|', "PGPASSWORD=/\"$db_pass/\" pg_dump -b -Fc --no-owner -h $host -p $port -U $db_user";
+ my $ok = open my $fh, '-|', "PGPASSWORD=\"$db_pass\" pg_dump -b -Fc --no-owner -h $host -p $port -U $db_user -d $db_name";
if (! $ok ) {
$self->internal_server_error( { Error => "Error dumping database" } );
return;
@@ -42,13 +42,11 @@ sub dbdump {
# slurp it in..
undef $/;
my $data = <$fh>;
- my $zipdata;
- gzip \$data => \$zipdata;
$self->res->headers->content_type("application/download");
$self->res->headers->content_disposition( "attachment; filename=\"" . $filename . "\"" );
- $self->render( data => $zipdata );
+ $self->render( data => $data );
close $fh;
}