You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/10/05 22:03:02 UTC

[GitHub] [lucene-solr] mayya-sharipova edited a comment on pull request #1943: LUCENE-9555 Advance conjuction Iterator for two phase iteration

mayya-sharipova edited a comment on pull request #1943:
URL: https://github.com/apache/lucene-solr/pull/1943#issuecomment-703885914


   @jpountz Sorry for the noise, I have found the cause of this error, and the latest commit addresses it.
   Basically this PR will just address the failing test of `TestUnifiedHighlighterStrictPhrases.testBasics`.
   
   My next steps will  the following:
   - use leap-frog logic without using ConjunctionDISI for this method  (a separate PR for that)
   - Then reintroduce again checks in  [ConjunctionDISI](https://github.com/apache/lucene-solr/pull/1937) that I reverted,  as sort optimization by introducing new iterators in the middle of iteration would break these checks.   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org