You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/10/08 10:12:18 UTC
[GitHub] [incubator-mxnet] agrabows opened a new pull request #20652: [FEATURE] Add oneDNN support for numpy concatenate operator
agrabows opened a new pull request #20652:
URL: https://github.com/apache/incubator-mxnet/pull/20652
## Description ##
Function concatenate() from module mxnet.numpy will now be executed by oneDNN primitives as it is done in module mxnet.ndarray. Additionally concat from mxnet.ndarray will gain numpy fuctionality which is flattening input arrays when parameter dim=None.
## Checklist ##
### Essentials ###
- [x] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
- [x] Changes are complete (i.e. I finished coding on this PR)
- [x] Code is well-documented
### Changes ###
- [x] Merge NNVM_REGISTER_OP(_npi_concatenate) with NNVM_REGISTER_OP(concatenate)
## Comments ##
It was possible to merge both ndarray and numpy concatenate operators into one NNVM_REGISTER_OP, additional functionality was added to ndarray concatenate by this process.
Performance tests from mxnet profiler with 10 warmup runs and 50 test runs of this operator are given below:
Numpy concatenate was about 9 times faster in those tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20652: [FEATURE] Add oneDNN support for numpy concatenate operator
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20652:
URL: https://github.com/apache/incubator-mxnet/pull/20652#issuecomment-947637010
Jenkins CI successfully triggered : [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20652: [FEATURE] Add oneDNN support for numpy concatenate operator
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20652:
URL: https://github.com/apache/incubator-mxnet/pull/20652#issuecomment-947584508
Jenkins CI successfully triggered : [centos-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] agrabows commented on pull request #20652: [FEATURE] Add oneDNN support for numpy concatenate operator
Posted by GitBox <gi...@apache.org>.
agrabows commented on pull request #20652:
URL: https://github.com/apache/incubator-mxnet/pull/20652#issuecomment-950744920
@mxnet-bot run ci [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] agrabows commented on pull request #20652: [FEATURE] Add oneDNN support for numpy concatenate operator
Posted by GitBox <gi...@apache.org>.
agrabows commented on pull request #20652:
URL: https://github.com/apache/incubator-mxnet/pull/20652#issuecomment-954561687
@mxnet-bot run ci [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20652: [FEATURE] Add oneDNN support for numpy concatenate operator
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20652:
URL: https://github.com/apache/incubator-mxnet/pull/20652#issuecomment-954561752
Jenkins CI successfully triggered : [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20652: [FEATURE] Add oneDNN support for numpy concatenate operator
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20652:
URL: https://github.com/apache/incubator-mxnet/pull/20652#issuecomment-938521285
Hey @agrabows , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [clang, edge, centos-gpu, unix-gpu, unix-cpu, sanity, miscellaneous, windows-gpu, centos-cpu, website, windows-cpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha merged pull request #20652: [FEATURE] Add oneDNN support for numpy concatenate operator
Posted by GitBox <gi...@apache.org>.
szha merged pull request #20652:
URL: https://github.com/apache/incubator-mxnet/pull/20652
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20652: [FEATURE] Add oneDNN support for numpy concatenate operator
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20652:
URL: https://github.com/apache/incubator-mxnet/pull/20652#issuecomment-950897014
Jenkins CI successfully triggered : [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on pull request #20652: [FEATURE] Add oneDNN support for numpy concatenate operator
Posted by GitBox <gi...@apache.org>.
szha commented on pull request #20652:
URL: https://github.com/apache/incubator-mxnet/pull/20652#issuecomment-955127178
@agrabows thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20652: [FEATURE] Add oneDNN support for numpy concatenate operator
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20652:
URL: https://github.com/apache/incubator-mxnet/pull/20652#issuecomment-950744970
Jenkins CI successfully triggered : [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20652: [FEATURE] Add oneDNN support for numpy concatenate operator
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20652:
URL: https://github.com/apache/incubator-mxnet/pull/20652#issuecomment-947466494
Jenkins CI successfully triggered : [centos-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20652: [FEATURE] Add oneDNN support for numpy concatenate operator
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20652:
URL: https://github.com/apache/incubator-mxnet/pull/20652#issuecomment-953923898
Jenkins CI successfully triggered : [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bartekkuncer commented on a change in pull request #20652: [FEATURE] Add oneDNN support for numpy concatenate operator
Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on a change in pull request #20652:
URL: https://github.com/apache/incubator-mxnet/pull/20652#discussion_r724903147
##########
File path: src/operator/nn/concat.cc
##########
@@ -251,8 +257,9 @@ bool SupportMKLDNNConcat(const std::vector<NDArray>& arrs) {
return false;
int ndim = arr.shape().ndim();
const int mkldnn_ndims = arr.GetMKLDNNData()->get_desc().data.ndims;
- if (!(ndim == 2 || ndim == 4) || ndim != mkldnn_ndims)
+ if ((ndim != 2 && ndim != 4) || ndim != mkldnn_ndims){
Review comment:
Missing space.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] agrabows commented on pull request #20652: [FEATURE] Add oneDNN support for numpy concatenate operator
Posted by GitBox <gi...@apache.org>.
agrabows commented on pull request #20652:
URL: https://github.com/apache/incubator-mxnet/pull/20652#issuecomment-947636896
@mxnet-bot run ci [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] agrabows commented on pull request #20652: [FEATURE] Add oneDNN support for numpy concatenate operator
Posted by GitBox <gi...@apache.org>.
agrabows commented on pull request #20652:
URL: https://github.com/apache/incubator-mxnet/pull/20652#issuecomment-947466422
@mxnet-bot run ci [centos-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] agrabows commented on pull request #20652: [FEATURE] Add oneDNN support for numpy concatenate operator
Posted by GitBox <gi...@apache.org>.
agrabows commented on pull request #20652:
URL: https://github.com/apache/incubator-mxnet/pull/20652#issuecomment-947584475
@mxnet-bot run ci [centos-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] agrabows commented on pull request #20652: [FEATURE] Add oneDNN support for numpy concatenate operator
Posted by GitBox <gi...@apache.org>.
agrabows commented on pull request #20652:
URL: https://github.com/apache/incubator-mxnet/pull/20652#issuecomment-950896927
@mxnet-bot run ci [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] agrabows commented on pull request #20652: [FEATURE] Add oneDNN support for numpy concatenate operator
Posted by GitBox <gi...@apache.org>.
agrabows commented on pull request #20652:
URL: https://github.com/apache/incubator-mxnet/pull/20652#issuecomment-954640184
@szha Could you please take a look and possibly merge this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20652: [FEATURE] Add oneDNN support for numpy concatenate operator
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20652:
URL: https://github.com/apache/incubator-mxnet/pull/20652#issuecomment-953923783
Jenkins CI successfully triggered : [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] agrabows commented on pull request #20652: [FEATURE] Add oneDNN support for numpy concatenate operator
Posted by GitBox <gi...@apache.org>.
agrabows commented on pull request #20652:
URL: https://github.com/apache/incubator-mxnet/pull/20652#issuecomment-953923699
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org