You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by prabhjyotsingh <gi...@git.apache.org> on 2017/02/27 07:20:41 UTC
[GitHub] zeppelin pull request #2074: ZEPPELIN-2148: On creation of Bar graph zeppeli...
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/zeppelin/pull/2074
ZEPPELIN-2148: On creation of Bar graph zeppelin UI shows it as minigraph
### What is this PR for?
This is an extension https://github.com/apache/zeppelin/pull/2063. Since that had a merge conflict.
### What type of PR is it?
[Bug Fix]
### What is the Jira issue?
* [ZEPPELIN-2148](https://issues.apache.org/jira/browse/ZEPPELIN-2148)
### How should this be tested?
Check screen shot.
### Screenshots (if appropriate)
Before:
After:
### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-2148_branch-0.7
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2074.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2074
----
commit ca1ea2e58d0e011476b5c83e3ae94a2b27668a73
Author: Prabhjyot Singh <pr...@gmail.com>
Date: 2017-02-27T07:18:06Z
ZEPPELIN-2148: On creation of Bar graph zeppelin UI shows it as minigraph
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2074: ZEPPELIN-2148: On creation of Bar graph zeppeli...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh closed the pull request at:
https://github.com/apache/zeppelin/pull/2074
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2074: ZEPPELIN-2148: On creation of Bar graph zeppelin UI sh...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2074
Sure. I will test and give you feedback soon!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2074: ZEPPELIN-2148: On creation of Bar graph zeppelin UI sh...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2074
@1ambda did you get time to review this ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2074: ZEPPELIN-2148: On creation of Bar graph zeppelin UI sh...
Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath commented on the issue:
https://github.com/apache/zeppelin/pull/2074
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2074: ZEPPELIN-2148: On creation of Bar graph zeppelin UI sh...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2074
@r-kamath, @felixcheung Please help review this as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2074: ZEPPELIN-2148: On creation of Bar graph zeppelin UI sh...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2074
@prabhjyotsingh sorry for late reply :sob:
- Tested and works well as described.
- `ng-if` is great implementation!, since they will re-draw
- It would be nice if we apply this implementation to current master by reverting #2063
(https://github.com/apache/zeppelin/blob/master/zeppelin-web/src/app/notebook/paragraph/result/result.html#L27-#L43)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2074: ZEPPELIN-2148: On creation of Bar graph zeppelin UI sh...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2074
Sure, I'll merge this soon, and have created a new PR https://github.com/apache/zeppelin/pull/2092 as this has merge conflict with master. Please feel free to review that as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2074: ZEPPELIN-2148: On creation of Bar graph zeppelin UI sh...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2074
@1ambda how about this, instead of `ng-show` use `ng-if` ? Can you test this out ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---