[GitHub] [flink] dawidwys commented on a diff in pull request #23223: [FLINK-32873][table] - Add config to allow disabling QUERY hints

["dawidwys (via GitHub)" <gi...@apache.org>]

dawidwys commented on code in PR #23223:
URL: https://github.com/apache/flink/pull/23223#discussion_r1339651834


##########
docs/layouts/shortcodes/generated/table_config_configuration.html:
##########
@@ -62,6 +62,12 @@
             <td>String</td>
             <td>The local time zone defines current session time zone id. It is used when converting to/from &lt;code&gt;TIMESTAMP WITH LOCAL TIME ZONE&lt;/code&gt;. Internally, timestamps with local time zone are always represented in the UTC time zone. However, when converting to data types that don't include a time zone (e.g. TIMESTAMP, TIME, or simply STRING), the session time zone is used during conversion. The input of option is either a full name such as "America/Los_Angeles", or a custom timezone id such as "GMT-08:00".</td>
         </tr>
+        <tr>
+            <td><h5>table.optimizer.query-hints.enabled</h5><br> <span class="label label-primary">Batch</span> <span class="label label-primary">Streaming</span></td>

Review Comment:
   Can we please follow what you agreed in the mailing list?
   
   I believe you settled on `table.optimizer.ignore-query-hints`, didn't you? Or has this discussion been inconclusive?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org