You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ignite.apache.org by vo...@apache.org on 2015/07/16 08:01:46 UTC

[13/13] incubator-ignite git commit: GG-1108: Review.

GG-1108: Review.


Project: http://git-wip-us.apache.org/repos/asf/incubator-ignite/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-ignite/commit/a05ed125
Tree: http://git-wip-us.apache.org/repos/asf/incubator-ignite/tree/a05ed125
Diff: http://git-wip-us.apache.org/repos/asf/incubator-ignite/diff/a05ed125

Branch: refs/heads/ignite-1108
Commit: a05ed125331e44c2a1ef29cb218d3ed1a53ea12c
Parents: fbbc303
Author: vozerov-gridgain <vo...@gridgain.com>
Authored: Thu Jul 16 08:24:00 2015 +0300
Committer: vozerov-gridgain <vo...@gridgain.com>
Committed: Thu Jul 16 08:24:00 2015 +0300

----------------------------------------------------------------------
 .../core/src/main/java/org/apache/ignite/internal/IgniteKernal.java | 1 +
 .../ignite/internal/processors/plugin/IgnitePluginProcessor.java    | 1 +
 2 files changed, 2 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-ignite/blob/a05ed125/modules/core/src/main/java/org/apache/ignite/internal/IgniteKernal.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/IgniteKernal.java b/modules/core/src/main/java/org/apache/ignite/internal/IgniteKernal.java
index 36b14f6..5eced59 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/IgniteKernal.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/IgniteKernal.java
@@ -1801,6 +1801,7 @@ public class IgniteKernal implements IgniteEx, IgniteMXBean, Externalizable {
                 }
             }
 
+            // TODO: This should be inside IgnitePluginProcessor.stop() I think.
             // Invoke callback on plugins.
             if (ctx.plugins() != null && ctx.plugins().allProviders() != null) {
                 for (PluginProvider plugin : ctx.plugins().allProviders()) {

http://git-wip-us.apache.org/repos/asf/incubator-ignite/blob/a05ed125/modules/core/src/main/java/org/apache/ignite/internal/processors/plugin/IgnitePluginProcessor.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/plugin/IgnitePluginProcessor.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/plugin/IgnitePluginProcessor.java
index f8d65c2..fe551b5 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/plugin/IgnitePluginProcessor.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/plugin/IgnitePluginProcessor.java
@@ -133,6 +133,7 @@ public class IgnitePluginProcessor extends GridProcessorAdapter {
     /** {@inheritDoc} */
     @Override public void start() throws IgniteCheckedException {
         for (PluginProvider plugin : plugins.values())
+            // TODO: Why not passing PluginContext here? We already have it at that point.
             plugin.onBeforeStart();
 
         ackPluginsInfo();