You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by "Sergei Nikulov (JIRA)" <ji...@apache.org> on 2014/02/06 20:44:11 UTC

[jira] [Created] (THRIFT-2352) msvc failed to compile thrift tests

Sergei Nikulov created THRIFT-2352:
--------------------------------------

             Summary: msvc failed to compile thrift tests
                 Key: THRIFT-2352
                 URL: https://issues.apache.org/jira/browse/THRIFT-2352
             Project: Thrift
          Issue Type: Bug
          Components: C++ - Library
    Affects Versions: 1.0
         Environment: Windows7/Visual Studio 2012
            Reporter: Sergei Nikulov
         Attachments: 0001-fixed-tests-compilation-on-windows.patch

Patch related to THRIFT-2029 and fixes two issues with test compilation with msvc.

1. Renamed small to tiny in test/DebugProtoTest.thrift
Rationale: generated code contains bool small; which is conflicted with macro definition picked up from windows.h > rpcndr.h > "#define small char" (refer to http://connect.microsoft.com/VisualStudio/feedback/details/775845/poorly-picked-names-in-rpcndr-h-have-a-high-chance-of-collision and http://stackoverflow.com/questions/21165891/is-small-a-keyword-in-c and http://code.opencv.org/issues/1041)

2. Use THRIFT_GETTIMEOFDAY instead of gettimeofday in lib/cpp/test/Benchmark.cpp because of absence of it on Windows





--
This message was sent by Atlassian JIRA
(v6.1.5#6160)