You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by rcompton <gi...@git.apache.org> on 2014/05/29 23:48:20 UTC
[GitHub] spark pull request: SPARK-1952 removed slf4j Pig conflicts
GitHub user rcompton opened a pull request:
https://github.com/apache/spark/pull/915
SPARK-1952 removed slf4j Pig conflicts
Removed jul-to-slf4j and jcl-over-slf4j to allow Pig scripts to register jars containing the Spark-1.0 assembly, cf https://issues.apache.org/jira/browse/SPARK-1952
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rcompton/spark my_branch-1.0
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/915.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #915
----
commit cadfca693e7e93ee4a393ce42cf04bccd7262522
Author: rcompton <co...@gmail.com>
Date: 2014-05-29T19:56:31Z
SPARK-1952 removed slf4j pig conflicts
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1952 removed slf4j Pig conflicts
Posted by rcompton <gi...@git.apache.org>.
Github user rcompton closed the pull request at:
https://github.com/apache/spark/pull/915
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-1952 removed slf4j Pig conflicts
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/915#issuecomment-44590733
As Patrick alluded to, those imports are on purpose, to direct logging from this like Pig that use JCL to the logging that the rest of the app uses. Because things like JCL have been excluded, also excluding these would cause libraries that use JCL to fail, so I don't think this can be included like this. The intended action would be to exclude JCL in your downstream app and keep this import. Of course you can get other effects, like rejiggering the whole setup to direct to JCL and not log4j. It's more, different work, but possible.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1952 removed slf4j Pig conflicts
Posted by mateiz <gi...@git.apache.org>.
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/915#issuecomment-53973167
@rcompton I believe this has been addressed by Sigmoid's recent work for Pig on Spark: https://issues.apache.org/jira/browse/PIG-4059. Given that, do we still need this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-1952 removed slf4j Pig conflicts
Posted by mateiz <gi...@git.apache.org>.
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/915#issuecomment-53973561
Alright, thanks for taking a look at this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-1952 removed slf4j Pig conflicts
Posted by rcompton <gi...@git.apache.org>.
Github user rcompton commented on the pull request:
https://github.com/apache/spark/pull/915#issuecomment-53973422
@mateiz no, for the reasons mentioned by Sean as well as the new work by Sigmoid, you don't need this patch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-1952 removed slf4j Pig conflicts
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/915#issuecomment-44590372
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---