[jira] [Commented] (HBASE-12781) Listen port will bind always to the passed command line address

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-12781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14261170#comment-14261170 ] 

Hadoop QA commented on HBASE-12781:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12689499/12781-V1.patch
  against master branch at commit 0513a21dc8b86f57b5a6c1b742904821632f77f7.
  ATTACHMENT ID: 12689499

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12258//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12258//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12258//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12258//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12258//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12258//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12258//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12258//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12258//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12258//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12258//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12258//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12258//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12258//console

This message is automatically generated.

> Listen port will bind always to the passed command line address
> ---------------------------------------------------------------
>
>                 Key: HBASE-12781
>                 URL: https://issues.apache.org/jira/browse/HBASE-12781
>             Project: HBase
>          Issue Type: Bug
>          Components: Thrift
>    Affects Versions: 0.98.3
>            Reporter: Pankaj Kumar
>            Assignee: Pankaj Kumar
>         Attachments: 12781-V1.patch
>
>
> In Thrift server,  listen port will bind always to the address which  is passed through command line argument. 
> ------
> InetSocketAddress inetSocketAddress = bindToPort(cmd.getOptionValue("bind"), listenPort);
> -----
> private static InetSocketAddress bindToPort(String bindValue, int listenPort)
>       throws UnknownHostException {
>     try {
>       if (bindValue == null) {
>         return new InetSocketAddress(listenPort);
>       } else {
>         return new InetSocketAddress(InetAddress.getByName(bindValue), listenPort);
>       }
>     } catch (UnknownHostException e) {
>       throw new RuntimeException("Could not bind to provided ip address", e);
>     }
>   }
> In case when bind address is not passed through argument then it is binding with any local  address. It should read hbase.thrift.info.bindAddress  value from configuration first.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)