You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/09/14 21:35:34 UTC
[GitHub] [hudi] bhasudha opened a new pull request, #6674: [DOCS] Standardize blog images sizes
bhasudha opened a new pull request, #6674:
URL: https://github.com/apache/hudi/pull/6674
### Change Logs
Changed the image size to a standard size of 1200 * 600 for most images for better rendering of blogs landing page.
### Impact
_Describe any public API or user-facing feature change or any performance impact._
**Risk level: none | low | medium | high**
_Choose one. If medium or high, explain what verification was done to mitigate the risks._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua commented on pull request #6674: [DOCS] Standardize blog images sizes
Posted by GitBox <gi...@apache.org>.
yihua commented on PR #6674:
URL: https://github.com/apache/hudi/pull/6674#issuecomment-1248776055
@bhasudha If needed, the images can be adjusted in a follow-up PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua commented on pull request #6674: [DOCS] Standardize blog images sizes
Posted by GitBox <gi...@apache.org>.
yihua commented on PR #6674:
URL: https://github.com/apache/hudi/pull/6674#issuecomment-1247343367
> I definitely agree. But a question or a thought is should it be okay to decouple that and fix individual images in a second PR. I want to do the bulk change quickly and go from there. But open to ideas. What do you think?
Given this is affecting how the website is visualized, let's have the changes to make images look better in one PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua merged pull request #6674: [DOCS] Standardize blog images sizes
Posted by GitBox <gi...@apache.org>.
yihua merged PR #6674:
URL: https://github.com/apache/hudi/pull/6674
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua commented on pull request #6674: [DOCS] Standardize blog images sizes
Posted by GitBox <gi...@apache.org>.
yihua commented on PR #6674:
URL: https://github.com/apache/hudi/pull/6674#issuecomment-1248766824
> Done. @yihua redrawing the entire image might be a bigger effort. I changed the images so their ratio does not change and are closer to 1200 * 600 either in width or height. Please take a look and flag any image that comes out odd.
Sg. I'll take a look. No need to redraw the images in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] bhasudha commented on pull request #6674: [DOCS] Standardize blog images sizes
Posted by GitBox <gi...@apache.org>.
bhasudha commented on PR #6674:
URL: https://github.com/apache/hudi/pull/6674#issuecomment-1247338781
>
I definitely agree. But a question or a thought is should it be okay to decouple that and fix individual images in a second PR. I want to do the bulk change quickly and go from there. But open to ideas. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] bhasudha commented on pull request #6674: [DOCS] Standardize blog images sizes
Posted by GitBox <gi...@apache.org>.
bhasudha commented on PR #6674:
URL: https://github.com/apache/hudi/pull/6674#issuecomment-1247371882
>
Done. @yihua redrawing the entire image might be a bigger effort. I changed the images so their ratio does not change and are closer to 1200 * 600 either in width or height. Please take a look and flag any image that comes out odd.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org