You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by davinash <gi...@git.apache.org> on 2016/11/19 09:44:10 UTC
[GitHub] incubator-geode pull request #291: [GEODE-1122] Fixed Dependency on environm...
GitHub user davinash opened a pull request:
https://github.com/apache/incubator-geode/pull/291
[GEODE-1122] Fixed Dependency on environment variable GEMFIRE needs to be removed
All Test Passing.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/davinash/incubator-geode feature/GEODE-1122
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-geode/pull/291.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #291
----
commit d8a2d94aae096444cca43ba3d1f3356421b8d439
Author: adongre <ad...@apache.org>
Date: 2016-11-16T06:59:12Z
GEODE-1122: Removing dependency on the environment variable GEMFIRE to GEODE_HOME
commit a91d1f278ea60b410876a22da44d7f44e65e1395
Author: adongre <ad...@apache.org>
Date: 2016-11-16T07:25:34Z
GEODE-1122: Updating gfsh scripts to use GEODE_HOME
commit ec204b51d45413a5cb17d91f9955db4083b95141
Author: adongre <ad...@apache.org>
Date: 2016-11-17T08:56:25Z
GEODE-1122: Fixing REST Related Dunit Tests.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode pull request #291: [GEODE-1122] Fixed Dependency on environm...
Posted by davinash <gi...@git.apache.org>.
Github user davinash commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/291#discussion_r88781685
--- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java ---
@@ -1493,6 +1495,7 @@ public Result startServer(
help = CliStrings.START_SERVER__PASSWORD__HELP) String passwordToUse)
// NOTICE: keep the parameters in alphabetical order based on their CliStrings.START_SERVER_* text
{
+ System.out.println("GEODE_HOME = " + GEODE_HOME);
--- End diff --
Fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode issue #291: [GEODE-1122] Fixed Dependency on environment var...
Posted by davinash <gi...@git.apache.org>.
Github user davinash commented on the issue:
https://github.com/apache/incubator-geode/pull/291
Thanks for Review @metatype
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode issue #291: [GEODE-1122] Fixed Dependency on environment var...
Posted by davinash <gi...@git.apache.org>.
Github user davinash commented on the issue:
https://github.com/apache/incubator-geode/pull/291
@metatype Thanks for the review,
I think I messed up in my local git repo. I am always getting
```
~/source/open/incubator-geode (feature/GEODE-1122) $ git flow feature finish -rF GEODE-1122
Branches 'develop' and 'origin/develop' have diverged.
Fatal: Branches need merging first.
```
I tried rebase and other solutions, but nothing is working.
Could you please help this time to merge this change to develop.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode pull request #291: [GEODE-1122] Fixed Dependency on environm...
Posted by metatype <gi...@git.apache.org>.
Github user metatype commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/291#discussion_r88781162
--- Diff: geode-assembly/src/test/java/org/apache/geode/management/internal/configuration/SharedConfigurationEndToEndDUnitTest.java ---
@@ -146,6 +146,8 @@ public void testStartServerAndExecuteCommands() throws Exception {
CommandResult cmdResult = executeCommand(gfsh, csb.getCommandString());
+ System.out.println("cmdResult = " + cmdResult);
--- End diff --
Is this code left-over from debugging?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode pull request #291: [GEODE-1122] Fixed Dependency on environm...
Posted by metatype <gi...@git.apache.org>.
Github user metatype commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/291#discussion_r88781054
--- Diff: geode-core/src/main/java/org/apache/geode/management/internal/AgentUtil.java ---
@@ -52,7 +52,7 @@ public AgentUtil(String gemfireVersion) {
* geode-web-api
*/
public String findWarLocation(String warFilePrefix) {
- String gemfireHome = getGemFireHome();
+ String gemfireHome = getGeodeHome();
--- End diff --
Can you update the above javadocs with GEODE_HOME instead of GEMFIRE?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode pull request #291: [GEODE-1122] Fixed Dependency on environm...
Posted by davinash <gi...@git.apache.org>.
Github user davinash commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/291#discussion_r88781673
--- Diff: geode-core/src/main/java/org/apache/geode/management/internal/AgentUtil.java ---
@@ -52,7 +52,7 @@ public AgentUtil(String gemfireVersion) {
* geode-web-api
*/
public String findWarLocation(String warFilePrefix) {
- String gemfireHome = getGemFireHome();
+ String gemfireHome = getGeodeHome();
--- End diff --
Fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode issue #291: [GEODE-1122] Fixed Dependency on environment var...
Posted by davinash <gi...@git.apache.org>.
Github user davinash commented on the issue:
https://github.com/apache/incubator-geode/pull/291
Is this PR now good for merge to develop now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode issue #291: [GEODE-1122] Fixed Dependency on environment var...
Posted by metatype <gi...@git.apache.org>.
Github user metatype commented on the issue:
https://github.com/apache/incubator-geode/pull/291
@davinash I think you merged `master` into your feature branch. I suggest closing this PR and starting a new one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode pull request #291: [GEODE-1122] Fixed Dependency on environm...
Posted by metatype <gi...@git.apache.org>.
Github user metatype commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/291#discussion_r88781178
--- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java ---
@@ -1493,6 +1495,7 @@ public Result startServer(
help = CliStrings.START_SERVER__PASSWORD__HELP) String passwordToUse)
// NOTICE: keep the parameters in alphabetical order based on their CliStrings.START_SERVER_* text
{
+ System.out.println("GEODE_HOME = " + GEODE_HOME);
--- End diff --
Please remove print statement.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode pull request #291: [GEODE-1122] Fixed Dependency on environm...
Posted by davinash <gi...@git.apache.org>.
Github user davinash commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/291#discussion_r88781680
--- Diff: geode-assembly/src/test/java/org/apache/geode/management/internal/configuration/SharedConfigurationEndToEndDUnitTest.java ---
@@ -146,6 +146,8 @@ public void testStartServerAndExecuteCommands() throws Exception {
CommandResult cmdResult = executeCommand(gfsh, csb.getCommandString());
+ System.out.println("cmdResult = " + cmdResult);
--- End diff --
Fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode pull request #291: [GEODE-1122] Fixed Dependency on environm...
Posted by davinash <gi...@git.apache.org>.
Github user davinash closed the pull request at:
https://github.com/apache/incubator-geode/pull/291
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---