You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2023/01/06 15:20:39 UTC
[GitHub] [superset] nisheldo opened a new pull request, #22623: chore: add chromium to build image
nisheldo opened a new pull request, #22623:
URL: https://github.com/apache/superset/pull/22623
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
Adding Chromium to the build docker stage along with https://github.com/apache/superset/pull/22615 will allow arm based users to finally build locally
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] EugeneTorap commented on a diff in pull request #22623: chore: skip puppeteer chromium download
Posted by GitBox <gi...@apache.org>.
EugeneTorap commented on code in PR #22623:
URL: https://github.com/apache/superset/pull/22623#discussion_r1069177921
##########
Dockerfile:
##########
@@ -23,6 +23,7 @@ FROM node:16-slim AS superset-node
ARG NPM_BUILD_CMD="build"
ENV BUILD_CMD=${NPM_BUILD_CMD}
+ENV PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=true
Review Comment:
@villebro Can we merge it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] EugeneTorap commented on a diff in pull request #22623: chore: skip puppeteer chromium download
Posted by GitBox <gi...@apache.org>.
EugeneTorap commented on code in PR #22623:
URL: https://github.com/apache/superset/pull/22623#discussion_r1064777544
##########
Dockerfile:
##########
@@ -23,6 +23,7 @@ FROM node:16-slim AS superset-node
ARG NPM_BUILD_CMD="build"
ENV BUILD_CMD=${NPM_BUILD_CMD}
+ENV PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=true
Review Comment:
I agree with you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] EugeneTorap commented on a diff in pull request #22623: chore: skip puppeteer chromium download
Posted by GitBox <gi...@apache.org>.
EugeneTorap commented on code in PR #22623:
URL: https://github.com/apache/superset/pull/22623#discussion_r1064552326
##########
Dockerfile:
##########
@@ -23,6 +23,7 @@ FROM node:16-slim AS superset-node
ARG NPM_BUILD_CMD="build"
ENV BUILD_CMD=${NPM_BUILD_CMD}
+ENV PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=true
Review Comment:
Why do we need to add `Chromium` to the image?
For what do we use `Puppeteer` in the superset? For UI testing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nisheldo commented on pull request #22623: chore: skip puppeteer chromium download
Posted by GitBox <gi...@apache.org>.
nisheldo commented on PR #22623:
URL: https://github.com/apache/superset/pull/22623#issuecomment-1374537400
@EugeneTorap - thx for the suggestion - I thought I had tried that before but apparently not - I changed to skip the chromium download in puppeteer instead of adding chromium to the image
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nisheldo commented on a diff in pull request #22623: chore: skip puppeteer chromium download
Posted by GitBox <gi...@apache.org>.
nisheldo commented on code in PR #22623:
URL: https://github.com/apache/superset/pull/22623#discussion_r1067327263
##########
Dockerfile:
##########
@@ -23,6 +23,7 @@ FROM node:16-slim AS superset-node
ARG NPM_BUILD_CMD="build"
ENV BUILD_CMD=${NPM_BUILD_CMD}
+ENV PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=true
Review Comment:
@villebro - done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro merged pull request #22623: chore: skip puppeteer chromium download
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro merged PR #22623:
URL: https://github.com/apache/superset/pull/22623
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a diff in pull request #22623: chore: skip puppeteer chromium download
Posted by GitBox <gi...@apache.org>.
villebro commented on code in PR #22623:
URL: https://github.com/apache/superset/pull/22623#discussion_r1064535970
##########
Dockerfile:
##########
@@ -23,6 +23,7 @@ FROM node:16-slim AS superset-node
ARG NPM_BUILD_CMD="build"
ENV BUILD_CMD=${NPM_BUILD_CMD}
+ENV PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=true
Review Comment:
Can we default this to `false`?
```suggestion
ENV PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=false
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a diff in pull request #22623: chore: skip puppeteer chromium download
Posted by GitBox <gi...@apache.org>.
villebro commented on code in PR #22623:
URL: https://github.com/apache/superset/pull/22623#discussion_r1066853176
##########
Dockerfile:
##########
@@ -23,6 +23,7 @@ FROM node:16-slim AS superset-node
ARG NPM_BUILD_CMD="build"
ENV BUILD_CMD=${NPM_BUILD_CMD}
+ENV PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=true
Review Comment:
Ok, I read through some docs. Am I right in the following assumptions?
- The env variable only blocks `puppeteer` from downloading chrome when the docker image is being built during `npm ci`
- We're not depending on this functionality indirectly despite pulling in `puppeteer` in our npm deps
@nisheldo please add a summary of what kind of error you're getting without this fix, preferably a dump of the docker build error you're seeing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] EugeneTorap commented on pull request #22623: chore: add chromium to build image
Posted by GitBox <gi...@apache.org>.
EugeneTorap commented on PR #22623:
URL: https://github.com/apache/superset/pull/22623#issuecomment-1374431575
@nisheldo Thanks for contribution! Why do we need to add `Chromium` to the image?
Maybe better to skip it via `ENV PUPPETEER_SKIP_CHROMIUM_DOWNLOAD true` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] EugeneTorap commented on pull request #22623: chore: skip puppeteer chromium download
Posted by GitBox <gi...@apache.org>.
EugeneTorap commented on PR #22623:
URL: https://github.com/apache/superset/pull/22623#issuecomment-1375443884
@villebro @dpgaspar What do you think about the PR? Can we merge it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] EugeneTorap commented on a diff in pull request #22623: chore: skip puppeteer chromium download
Posted by GitBox <gi...@apache.org>.
EugeneTorap commented on code in PR #22623:
URL: https://github.com/apache/superset/pull/22623#discussion_r1064552326
##########
Dockerfile:
##########
@@ -23,6 +23,7 @@ FROM node:16-slim AS superset-node
ARG NPM_BUILD_CMD="build"
ENV BUILD_CMD=${NPM_BUILD_CMD}
+ENV PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=true
Review Comment:
Why do we need to add `Chromium` to the image?
For what do we use `Puppeteer` in the superset?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nisheldo commented on a diff in pull request #22623: chore: skip puppeteer chromium download
Posted by GitBox <gi...@apache.org>.
nisheldo commented on code in PR #22623:
URL: https://github.com/apache/superset/pull/22623#discussion_r1067267954
##########
Dockerfile:
##########
@@ -23,6 +23,7 @@ FROM node:16-slim AS superset-node
ARG NPM_BUILD_CMD="build"
ENV BUILD_CMD=${NPM_BUILD_CMD}
+ENV PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=true
Review Comment:
@villebro - this is the error you get without the fix
` > [superset-node 7/8] RUN /frontend-mem-nag.sh && cd /app/superset-frontend && npm ci:
#18 0.141 Memory check Ok [12.1407 GB free]
#18 108.2 npm notice
#18 108.2 npm notice New major version of npm available! 7.24.2 -> 9.2.0
#18 108.2 npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.2.0>
#18 108.2 npm notice Run `npm install -g npm@9.2.0` to update!
#18 108.2 npm notice
#18 108.2 npm ERR! code 1
#18 108.2 npm ERR! path /app/superset-frontend/node_modules/puppeteer
#18 108.2 npm ERR! command failed
#18 108.2 npm ERR! command sh -c node install.js
#18 108.2 npm ERR! The chromium binary is not available for arm64.
#18 108.2 npm ERR! If you are on Ubuntu, you can install with:
#18 108.2 npm ERR!
#18 108.2 npm ERR! sudo apt install chromium
#18 108.2 npm ERR!
#18 108.2 npm ERR!
#18 108.2 npm ERR! sudo apt install chromium-browser
#18 108.2 npm ERR!
#18 108.2 npm ERR! /app/superset-frontend/node_modules/puppeteer/lib/cjs/puppeteer/node/BrowserFetcher.js:115
#18 108.2 npm ERR! throw new Error();
#18 108.2 npm ERR! ^
#18 108.2 npm ERR!
#18 108.2 npm ERR! Error
#18 108.2 npm ERR! at /app/superset-frontend/node_modules/puppeteer/lib/cjs/puppeteer/node/BrowserFetcher.js:115:27
#18 108.2 npm ERR! at FSReqCallback.oncomplete (node:fs:202:21)
#18 108.3
#18 108.3 npm ERR! A complete log of this run can be found in:
#18 108.3 npm ERR! /root/.npm/_logs/2023-01-11T17_24_26_860Z-debug.log`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nisheldo commented on a diff in pull request #22623: chore: skip puppeteer chromium download
Posted by GitBox <gi...@apache.org>.
nisheldo commented on code in PR #22623:
URL: https://github.com/apache/superset/pull/22623#discussion_r1067267954
##########
Dockerfile:
##########
@@ -23,6 +23,7 @@ FROM node:16-slim AS superset-node
ARG NPM_BUILD_CMD="build"
ENV BUILD_CMD=${NPM_BUILD_CMD}
+ENV PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=true
Review Comment:
@villebro - this is the error you get without the fix
> [superset-node 7/8] RUN /frontend-mem-nag.sh && cd /app/superset-frontend && npm ci:
#18 0.141 Memory check Ok [12.1407 GB free]
#18 108.2 npm notice
#18 108.2 npm notice New major version of npm available! 7.24.2 -> 9.2.0
#18 108.2 npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.2.0>
#18 108.2 npm notice Run `npm install -g npm@9.2.0` to update!
#18 108.2 npm notice
#18 108.2 npm ERR! code 1
#18 108.2 npm ERR! path /app/superset-frontend/node_modules/puppeteer
#18 108.2 npm ERR! command failed
#18 108.2 npm ERR! command sh -c node install.js
#18 108.2 npm ERR! The chromium binary is not available for arm64.
#18 108.2 npm ERR! If you are on Ubuntu, you can install with:
#18 108.2 npm ERR!
#18 108.2 npm ERR! sudo apt install chromium
#18 108.2 npm ERR!
#18 108.2 npm ERR!
#18 108.2 npm ERR! sudo apt install chromium-browser
#18 108.2 npm ERR!
#18 108.2 npm ERR! /app/superset-frontend/node_modules/puppeteer/lib/cjs/puppeteer/node/BrowserFetcher.js:115
#18 108.2 npm ERR! throw new Error();
#18 108.2 npm ERR! ^
#18 108.2 npm ERR!
#18 108.2 npm ERR! Error
#18 108.2 npm ERR! at /app/superset-frontend/node_modules/puppeteer/lib/cjs/puppeteer/node/BrowserFetcher.js:115:27
#18 108.2 npm ERR! at FSReqCallback.oncomplete (node:fs:202:21)
#18 108.3
#18 108.3 npm ERR! A complete log of this run can be found in:
#18 108.3 npm ERR! /root/.npm/_logs/2023-01-11T17_24_26_860Z-debug.log
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a diff in pull request #22623: chore: skip puppeteer chromium download
Posted by GitBox <gi...@apache.org>.
villebro commented on code in PR #22623:
URL: https://github.com/apache/superset/pull/22623#discussion_r1067317456
##########
Dockerfile:
##########
@@ -23,6 +23,7 @@ FROM node:16-slim AS superset-node
ARG NPM_BUILD_CMD="build"
ENV BUILD_CMD=${NPM_BUILD_CMD}
+ENV PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=true
Review Comment:
Thanks @nisheldo - can you add it to the description to improve discoverability?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] EugeneTorap commented on a diff in pull request #22623: chore: skip puppeteer chromium download
Posted by GitBox <gi...@apache.org>.
EugeneTorap commented on code in PR #22623:
URL: https://github.com/apache/superset/pull/22623#discussion_r1066840209
##########
Dockerfile:
##########
@@ -23,6 +23,7 @@ FROM node:16-slim AS superset-node
ARG NPM_BUILD_CMD="build"
ENV BUILD_CMD=${NPM_BUILD_CMD}
+ENV PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=true
Review Comment:
@villebro ^^
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] EugeneTorap commented on a diff in pull request #22623: chore: skip puppeteer chromium download
Posted by "EugeneTorap (via GitHub)" <gi...@apache.org>.
EugeneTorap commented on code in PR #22623:
URL: https://github.com/apache/superset/pull/22623#discussion_r1091057474
##########
Dockerfile:
##########
@@ -23,6 +23,7 @@ FROM node:16-slim AS superset-node
ARG NPM_BUILD_CMD="build"
ENV BUILD_CMD=${NPM_BUILD_CMD}
+ENV PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=true
Review Comment:
@rusackas I think we can merge it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] EugeneTorap commented on a diff in pull request #22623: chore: skip puppeteer chromium download
Posted by "EugeneTorap (via GitHub)" <gi...@apache.org>.
EugeneTorap commented on code in PR #22623:
URL: https://github.com/apache/superset/pull/22623#discussion_r1091057474
##########
Dockerfile:
##########
@@ -23,6 +23,7 @@ FROM node:16-slim AS superset-node
ARG NPM_BUILD_CMD="build"
ENV BUILD_CMD=${NPM_BUILD_CMD}
+ENV PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=true
Review Comment:
@rusackas I think we can merge it
##########
Dockerfile:
##########
@@ -23,6 +23,7 @@ FROM node:16-slim AS superset-node
ARG NPM_BUILD_CMD="build"
ENV BUILD_CMD=${NPM_BUILD_CMD}
+ENV PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=true
Review Comment:
@villebro Can we merge it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] EugeneTorap commented on a diff in pull request #22623: chore: skip puppeteer chromium download
Posted by GitBox <gi...@apache.org>.
EugeneTorap commented on code in PR #22623:
URL: https://github.com/apache/superset/pull/22623#discussion_r1066871397
##########
Dockerfile:
##########
@@ -23,6 +23,7 @@ FROM node:16-slim AS superset-node
ARG NPM_BUILD_CMD="build"
ENV BUILD_CMD=${NPM_BUILD_CMD}
+ENV PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=true
Review Comment:
All our team also uses Mac M1 and we have problem with ´puppeteer´ lib on arm64 image build and we skip downloading of the lib.
@michael-s-molina @kgabryje Can we speed up downloading of the UI libs while building a docker image? For example: skip all libs for unit test when we run ´npn ci´?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nisheldo commented on a diff in pull request #22623: chore: skip puppeteer chromium download
Posted by GitBox <gi...@apache.org>.
nisheldo commented on code in PR #22623:
URL: https://github.com/apache/superset/pull/22623#discussion_r1067267954
##########
Dockerfile:
##########
@@ -23,6 +23,7 @@ FROM node:16-slim AS superset-node
ARG NPM_BUILD_CMD="build"
ENV BUILD_CMD=${NPM_BUILD_CMD}
+ENV PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=true
Review Comment:
@villebro - this is the error you get without the fix if you are on a m1 mac
> [superset-node 7/8] RUN /frontend-mem-nag.sh && cd /app/superset-frontend && npm ci:
#18 0.141 Memory check Ok [12.1407 GB free]
#18 108.2 npm notice
#18 108.2 npm notice New major version of npm available! 7.24.2 -> 9.2.0
#18 108.2 npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.2.0>
#18 108.2 npm notice Run `npm install -g npm@9.2.0` to update!
#18 108.2 npm notice
#18 108.2 npm ERR! code 1
#18 108.2 npm ERR! path /app/superset-frontend/node_modules/puppeteer
#18 108.2 npm ERR! command failed
#18 108.2 npm ERR! command sh -c node install.js
#18 108.2 npm ERR! The chromium binary is not available for arm64.
#18 108.2 npm ERR! If you are on Ubuntu, you can install with:
#18 108.2 npm ERR!
#18 108.2 npm ERR! sudo apt install chromium
#18 108.2 npm ERR!
#18 108.2 npm ERR!
#18 108.2 npm ERR! sudo apt install chromium-browser
#18 108.2 npm ERR!
#18 108.2 npm ERR! /app/superset-frontend/node_modules/puppeteer/lib/cjs/puppeteer/node/BrowserFetcher.js:115
#18 108.2 npm ERR! throw new Error();
#18 108.2 npm ERR! ^
#18 108.2 npm ERR!
#18 108.2 npm ERR! Error
#18 108.2 npm ERR! at /app/superset-frontend/node_modules/puppeteer/lib/cjs/puppeteer/node/BrowserFetcher.js:115:27
#18 108.2 npm ERR! at FSReqCallback.oncomplete (node:fs:202:21)
#18 108.3
#18 108.3 npm ERR! A complete log of this run can be found in:
#18 108.3 npm ERR! /root/.npm/_logs/2023-01-11T17_24_26_860Z-debug.log
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] EugeneTorap commented on a diff in pull request #22623: chore: skip puppeteer chromium download
Posted by GitBox <gi...@apache.org>.
EugeneTorap commented on code in PR #22623:
URL: https://github.com/apache/superset/pull/22623#discussion_r1064552326
##########
Dockerfile:
##########
@@ -23,6 +23,7 @@ FROM node:16-slim AS superset-node
ARG NPM_BUILD_CMD="build"
ENV BUILD_CMD=${NPM_BUILD_CMD}
+ENV PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=true
Review Comment:
Why do we need to add `Chromium` to the image?
What do we use `Puppeteer` for?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nisheldo commented on a diff in pull request #22623: chore: skip puppeteer chromium download
Posted by GitBox <gi...@apache.org>.
nisheldo commented on code in PR #22623:
URL: https://github.com/apache/superset/pull/22623#discussion_r1064749906
##########
Dockerfile:
##########
@@ -23,6 +23,7 @@ FROM node:16-slim AS superset-node
ARG NPM_BUILD_CMD="build"
ENV BUILD_CMD=${NPM_BUILD_CMD}
+ENV PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=true
Review Comment:
Puppeteer is a dependency of Apitools - that runs a cron in github actions
Not actually needed in the docker image build - skipping the download in the dockerfile wont affect the apitools tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a diff in pull request #22623: chore: skip puppeteer chromium download
Posted by GitBox <gi...@apache.org>.
villebro commented on code in PR #22623:
URL: https://github.com/apache/superset/pull/22623#discussion_r1067318736
##########
Dockerfile:
##########
@@ -23,6 +23,7 @@ FROM node:16-slim AS superset-node
ARG NPM_BUILD_CMD="build"
ENV BUILD_CMD=${NPM_BUILD_CMD}
+ENV PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=true
Review Comment:
Funny thing is, I'm on an M1, too, but haven't run into this, so I guess I'm not using the `Dockerfile` that much locally 😁
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org