You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by dmorilha <gi...@git.apache.org> on 2016/02/07 20:55:31 UTC
[GitHub] trafficserver pull request: TS-4132 Open source Yahoo's ats-inline...
GitHub user dmorilha opened a pull request:
https://github.com/apache/trafficserver/pull/459
TS-4132 Open source Yahoo's ats-inliner plug-in
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dmorilha/trafficserver inliner
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/459.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #459
----
commit 44ffbf5659f890b6b2867fd0c00245d0b8004ed6
Author: Daniel Morilha <dm...@yahoo-inc.com>
Date: 2016-01-12T02:20:11Z
inliner initial commit
commit 8645587d35af9f6b8b0441825db453e3bbdfadf3
Author: Daniel Vitor Morilha <dm...@yahoo-inc.com>
Date: 2016-01-15T12:31:13Z
clang-format
commit 8845d4acbc574cbd7d1e68b98155210675c91179
Author: Daniel Vitor Morilha <dm...@yahoo-inc.com>
Date: 2016-01-15T12:33:13Z
updating NOTICE and Makefile.am
commit c8dfaa07f0e9b553f5363f0714b973feb1481371
Author: Daniel Vitor Morilha <dm...@yahoo-inc.com>
Date: 2016-02-07T16:53:36Z
Merge remote-tracking branch 'origin/master' into HEAD
commit 4240d263acde7b36d51ebaf828fdd5809178ac42
Author: Daniel Vitor Morilha <dm...@yahoo-inc.com>
Date: 2016-02-07T17:00:00Z
adding Makefile.am
commit 23a70d7e64dd9d6fee2dff1c95e66d33ef6e3a5a
Author: Daniel Vitor Morilha <dm...@yahoo-inc.com>
Date: 2016-02-07T17:46:21Z
adding inliner into configure.ac
commit bc4492003355bcb8a4e5080be479736175e7e168
Author: Daniel Vitor Morilha <dm...@yahoo-inc.com>
Date: 2016-02-07T19:48:47Z
removing define __STDC_FORMAT_MACROS
commit 5c89aa9ebea2e656411bab6cb233d5bc23644717
Author: Daniel Vitor Morilha <dm...@yahoo-inc.com>
Date: 2016-02-07T19:49:30Z
migrating to 64bit integer
commit 1d0b6d8e9f1a85501645b58a868f12d8f9ccd945
Author: Daniel Vitor Morilha <dm...@yahoo-inc.com>
Date: 2016-02-07T19:50:19Z
migrating to 64bit integer
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4132 Open source Yahoo's ats-inline...
Posted by sc0ttbeardsley <gi...@git.apache.org>.
Github user sc0ttbeardsley commented on the pull request:
https://github.com/apache/trafficserver/pull/459#issuecomment-182003287
@dmorilha ya, looks pretty good. We should add some details about adding the remaps for image asset urls since that is a bit tricky. Also we should add in this image?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4132 Open source Yahoo's ats-inline...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/459#issuecomment-181598361
Let's squash this branch a bit to improve clarity. All the code changes should go into the first commit, then the build integration and documentation in the second.
WRT ``printf`` formats, please use ``PRId64``.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4132 Open source Yahoo's ats-inline...
Posted by dmorilha <gi...@git.apache.org>.
Github user dmorilha commented on the pull request:
https://github.com/apache/trafficserver/pull/459#issuecomment-181603731
@jpeach all done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4132 Open source Yahoo's ats-inline...
Posted by mlibbey <gi...@git.apache.org>.
Github user mlibbey commented on the pull request:
https://github.com/apache/trafficserver/pull/459#issuecomment-181897910
Re: doc. I think the read me is a great start. Is the plugin a global or remap plugin?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4132 Open source Yahoo's ats-inline...
Posted by bryancall <gi...@git.apache.org>.
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/459#issuecomment-182093202
I reviewed this before in our work repository and I am happy with it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4132 Open source Yahoo's ats-inline...
Posted by sc0ttbeardsley <gi...@git.apache.org>.
Github user sc0ttbeardsley commented on the pull request:
https://github.com/apache/trafficserver/pull/459#issuecomment-182104126
@mlibbey it is a global plugin. @dmorilha we should add a "how to configure and use" section in the readme. I'll send you a PR if I get a chance
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4132 Open source Yahoo's ats-inline...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/459
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4132 Open source Yahoo's ats-inline...
Posted by dmorilha <gi...@git.apache.org>.
Github user dmorilha commented on the pull request:
https://github.com/apache/trafficserver/pull/459#issuecomment-181596121
@sc0ttbeardsley do you think this `README` files explains it well? https://github.com/dmorilha/trafficserver/blob/28456734fbc604b0115d1582dd2bf1b230263cdf/plugins/experimental/inliner/README
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4132 Open source Yahoo's ats-inline...
Posted by dmorilha <gi...@git.apache.org>.
Github user dmorilha commented on the pull request:
https://github.com/apache/trafficserver/pull/459#issuecomment-181726588
good point!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4132 Open source Yahoo's ats-inline...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/459#issuecomment-181698564
@dmorilha You mean ```"%" PRId64 ""```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4132 Open source Yahoo's ats-inline...
Posted by dmorilha <gi...@git.apache.org>.
Github user dmorilha commented on the pull request:
https://github.com/apache/trafficserver/pull/459#issuecomment-182034464
I will make sure to squash it again once we reach an agreement here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---