You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "Robert Burke (Jira)" <ji...@apache.org> on 2022/01/13 18:58:00 UTC

[jira] [Comment Edited] (BEAM-10206) [Go SDK] Jenkins static checks

    [ https://issues.apache.org/jira/browse/BEAM-10206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17475644#comment-17475644 ] 

Robert Burke edited comment on BEAM-10206 at 1/13/22, 6:57 PM:
---------------------------------------------------------------

We should go ahead and use a Github Action for this.
https://staticcheck.io/docs/running-staticcheck/github-actions/

Adding it to https://github.com/apache/beam/blob/master/.github/workflows/go_tests.yml

But also ensure go vet ./... runs clean before adding it to keep it from starting out perma-red.


was (Author: lostluck):
We should go ahead and use a Github Action for this.
https://staticcheck.io/docs/running-staticcheck/github-actions/

But also ensure go vet ./... runs clean before adding it to keep it from starting out perma-red.

> [Go SDK] Jenkins static checks  
> --------------------------------
>
>                 Key: BEAM-10206
>                 URL: https://issues.apache.org/jira/browse/BEAM-10206
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-go
>            Reporter: Robert Burke
>            Priority: P3
>
> We should probably hook up static checks [https://staticcheck.io|https://staticcheck.io/] to avoid style and lint regressions, and to run them locally and fix most of them.
> Additional configuration we could probably integrate should take the proto import conventions we've established (see PR 11927) so that we use consistent short names.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)