You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Nitin Mehta <ni...@citrix.com> on 2013/02/01 10:20:52 UTC
Re: Review Request: Multiple snapshots on a volume failing on XenServer 6.1.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8623/#review15999
-----------------------------------------------------------
Ship it!
Ship It!
- Nitin Mehta
On Dec. 16, 2012, 10:46 a.m., Devdeep Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8623/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2012, 10:46 a.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> CS-16544: Create Snapshot (2nd time - reccuring) is failing on XenServer 6.1. The issue is that while backing up a snapshot when cloudstack tries to update the parent (of the backed up vhd), vhd-util isn't present at the desired location and setParent function in vmopsSnapshot fails. This issue is observed only on Xenserver 6.1. The reason for this is, when CloudStack connects to a Xenserver and executes the SetupCommand, it copies vhd-util tool to /opt/xensource/bin directory on the host. However, in vmopsSnapshot python file 'VHD_UTIL' is initialized to /usr/sbin/. The issue is not observed on 6.0.2 (and I guess previous versions) because vhd-util is present in /usr/sbin/ directory by default (after a clean install). Whereas, in Xenserver 6.1, vhd-util is present in '/usr/bin'. Fixed the issue by updating VHD_UTIL to point to /opt/xensource/bin/vhd-util in vmopsSnapshot file.
>
>
> This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-647.
>
>
> Diffs
> -----
>
> scripts/vm/hypervisor/xenserver/vmopsSnapshot 80e21f8
>
> Diff: https://reviews.apache.org/r/8623/diff/
>
>
> Testing
> -------
>
> Tested by taking multiple snapshots of the same volume.
>
>
> Thanks,
>
> Devdeep Singh
>
>
Re: Review Request: Multiple snapshots on a volume failing on XenServer 6.1.
Posted by Devdeep Singh <de...@citrix.com>.
> On Feb. 1, 2013, 9:20 a.m., Nitin Mehta wrote:
> > Ship It!
Thanks, closing the review as the changes have been submitted.
- Devdeep
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8623/#review15999
-----------------------------------------------------------
On Dec. 16, 2012, 10:46 a.m., Devdeep Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8623/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2012, 10:46 a.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> CS-16544: Create Snapshot (2nd time - reccuring) is failing on XenServer 6.1. The issue is that while backing up a snapshot when cloudstack tries to update the parent (of the backed up vhd), vhd-util isn't present at the desired location and setParent function in vmopsSnapshot fails. This issue is observed only on Xenserver 6.1. The reason for this is, when CloudStack connects to a Xenserver and executes the SetupCommand, it copies vhd-util tool to /opt/xensource/bin directory on the host. However, in vmopsSnapshot python file 'VHD_UTIL' is initialized to /usr/sbin/. The issue is not observed on 6.0.2 (and I guess previous versions) because vhd-util is present in /usr/sbin/ directory by default (after a clean install). Whereas, in Xenserver 6.1, vhd-util is present in '/usr/bin'. Fixed the issue by updating VHD_UTIL to point to /opt/xensource/bin/vhd-util in vmopsSnapshot file.
>
>
> This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-647.
>
>
> Diffs
> -----
>
> scripts/vm/hypervisor/xenserver/vmopsSnapshot 80e21f8
>
> Diff: https://reviews.apache.org/r/8623/diff/
>
>
> Testing
> -------
>
> Tested by taking multiple snapshots of the same volume.
>
>
> Thanks,
>
> Devdeep Singh
>
>
Re: Review Request: Multiple snapshots on a volume failing on
XenServer 6.1.
Posted by Nitin Mehta <Ni...@citrix.com>.
Submitted with
commit e162876605a31a4687ac77c5554e0a15ea7dda55
Author: Devdeep Singh <de...@citrix.com>
Date: Fri Feb 1 15:25:26 2013 +0530
From: Nitin Mehta <ni...@citrix.com>>
Reply-To: Nitin Mehta <ni...@citrix.com>>
To: "cloudstack-dev@incubator.apache.org<ma...@incubator.apache.org>" <cl...@incubator.apache.org>>, Devdeep Singh <de...@citrix.com>>, Nitin Mehta <ni...@citrix.com>>
Subject: Re: Review Request: Multiple snapshots on a volume failing on XenServer 6.1.
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8623/
Ship it!
Ship It!
- Nitin
On December 16th, 2012, 10:46 a.m., Devdeep Singh wrote:
Review request for cloudstack.
By Devdeep Singh.
Updated Dec. 16, 2012, 10:46 a.m.
Description
CS-16544: Create Snapshot (2nd time - reccuring) is failing on XenServer 6.1. The issue is that while backing up a snapshot when cloudstack tries to update the parent (of the backed up vhd), vhd-util isn't present at the desired location and setParent function in vmopsSnapshot fails. This issue is observed only on Xenserver 6.1. The reason for this is, when CloudStack connects to a Xenserver and executes the SetupCommand, it copies vhd-util tool to /opt/xensource/bin directory on the host. However, in vmopsSnapshot python file 'VHD_UTIL' is initialized to /usr/sbin/. The issue is not observed on 6.0.2 (and I guess previous versions) because vhd-util is present in /usr/sbin/ directory by default (after a clean install). Whereas, in Xenserver 6.1, vhd-util is present in '/usr/bin'. Fixed the issue by updating VHD_UTIL to point to /opt/xensource/bin/vhd-util in vmopsSnapshot file.
Testing
Tested by taking multiple snapshots of the same volume.
Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-647
Diffs
* scripts/vm/hypervisor/xenserver/vmopsSnapshot (80e21f8)
View Diff<https://reviews.apache.org/r/8623/diff/>