You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flink.apache.org by zentol <gi...@git.apache.org> on 2017/06/27 10:45:22 UTC
[GitHub] flink-shaded pull request #3: [FLINK-7007] Add README.md
GitHub user zentol opened a pull request:
https://github.com/apache/flink-shaded/pull/3
[FLINK-7007] Add README.md
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink-shaded 7007
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink-shaded/pull/3.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3
----
commit e3e2588cd3f714dba16cfe328eb22f018bf1e1b4
Author: zentol <ch...@apache.org>
Date: 2017-06-27T10:44:23Z
[FLINK-7007] Add README.md
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink-shaded pull request #3: [FLINK-7007] Add README.md
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink-shaded/pull/3#discussion_r124335176
--- Diff: README.md ---
@@ -0,0 +1,28 @@
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+# Apache Flink Shaded Dependencies
+
+This repository contains a number of shaded dependencies for the [Apache Flink](https://flink.apache.org/) project.
+
+The purpose of these dependencies is to provide a single instance of a shaded dependency in the Flink distribution, instead of each individual module shading the dependency.
+
+The shaded dependencies contained here do not expose any transitive dependencies. They may or may not be self-contained.
+
+When using these dependencies it is recommended to work directly against the shaded namespaces.
--- End diff --
Could you add the following
```
About
Apache Flink is an open source project of The Apache Software Foundation (ASF).
```
and link to the ASF?
Other than that +1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink-shaded pull request #3: [FLINK-7007] Add README.md
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink-shaded/pull/3
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---