[GitHub] [incubator-superset] ktmud commented on pull request #10518: fix(sqllab): Handle long table names in SQL Lab

[GitBox <gi...@apache.org>]

ktmud commented on pull request #10518:
URL: https://github.com/apache/incubator-superset/pull/10518#issuecomment-669414805


   I implemented the feature where long table names [auto-expand](https://github.com/apache/incubator-superset/blob/428ad70aac150e988a5729ade22b72d9e318333f/superset-frontend/src/components/Select/styles.tsx#L167-L168) the dropdown select. This is done only for non-virtualized list because it was easier. Didn't follow up to fix it for the virtualized list because once users start typing and narrow the list down to < 100 items, it becomes a non-virtualized list and will auto-expand anyway.
   
   We can potentially slightly increase the `windowThreshold` (currently defaults to 100) on [Select](https://github.com/apache/incubator-superset/blob/671461d0d03ccc7ac1d7bef9cf1a5d9c1f39fdeb/superset-frontend/src/components/TableSelector.jsx#L367) to make table name truncating less frequent for users.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org