You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/07/10 10:49:09 UTC

[GitHub] [incubator-apisix] membphis opened a new issue #1827: test: add test case about failed to find upstream by id

membphis opened a new issue #1827:
URL: https://github.com/apache/incubator-apisix/issues/1827


   need to add test case about failed to find upstream by id:
   
   https://github.com/apache/incubator-apisix/pull/1824/files#diff-d982d52466e7c93c7b604358339b2a29R320
   
   we need to confirm it works fine.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-apisix] membphis commented on issue #1827: test: add test case about failed to find upstream by id

Posted by GitBox <gi...@apache.org>.
membphis commented on issue #1827:
URL: https://github.com/apache/incubator-apisix/issues/1827#issuecomment-656616047


   ![image](https://user-images.githubusercontent.com/6814606/87147410-2dcb1180-c2df-11ea-925c-e163646da406.png)
   
   I do not think we have added test cases for those codes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-apisix] membphis closed issue #1827: test: add test case about failed to find upstream by id

Posted by GitBox <gi...@apache.org>.
membphis closed issue #1827:
URL: https://github.com/apache/incubator-apisix/issues/1827


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-apisix] membphis commented on issue #1827: test: add test case about failed to find upstream by id

Posted by GitBox <gi...@apache.org>.
membphis commented on issue #1827:
URL: https://github.com/apache/incubator-apisix/issues/1827#issuecomment-656613012


   @wrl96 do you want to fix this issue?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-apisix] wrl96 commented on issue #1827: test: add test case about failed to find upstream by id

Posted by GitBox <gi...@apache.org>.
wrl96 commented on issue #1827:
URL: https://github.com/apache/incubator-apisix/issues/1827#issuecomment-656615035


   test case already in route-upstream.t
   it can't pass the test case if it doesn't work fine.
   https://github.com/apache/incubator-apisix/pull/1824/checks?sha=fe1c4f1450c0e911e857a6c6c0a1ef2836755bc2


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-apisix] membphis commented on issue #1827: test: add test case about failed to find upstream by id

Posted by GitBox <gi...@apache.org>.
membphis commented on issue #1827:
URL: https://github.com/apache/incubator-apisix/issues/1827#issuecomment-656686189


   we have covered this case. close this issue first


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org