You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by gw...@apache.org on 2019/08/25 21:31:03 UTC

[kafka] branch 2.3 updated: KAFKA-8391; Temporarily ignore flaky Connect rebalance integration tests

This is an automated email from the ASF dual-hosted git repository.

gwenshap pushed a commit to branch 2.3
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/2.3 by this push:
     new b99013c  KAFKA-8391; Temporarily ignore flaky Connect rebalance integration tests
b99013c is described below

commit b99013ca11df86e9d0527ca7bea1d386cb61378c
Author: Randall Hauch <rh...@gmail.com>
AuthorDate: Sun Aug 25 14:30:23 2019 -0700

    KAFKA-8391; Temporarily ignore flaky Connect rebalance integration tests
    
    I've spent quite a bit of time on trying to discover the root cause, with no luck so far. I have been able to reproduce it locally by running the following 100 times:
    ```
    ./gradlew connect:runtime:clean connect:runtime:test --tests org.apache.kafka.connect.integration.RebalanceSourceConnectorsIntegrationTest
    ```
    The `testReconfigConnector` test failed 28% of the time and the others failed 0%. This issue and KAFKA-8661 suggest that `testDeleteConnector` and `testStartTwoConnectors` are also flaky, though I've not seen those tests fail locally.
    
    Because this flakiness is causing issues for the rest of the project, I'm going to temporarily ignore several of the flaky ITs while I continue to investigate:
    * `RebalanceSourceConnectorsIntegrationTest.testReconfigConnector`
    * `RebalanceSourceConnectorsIntegrationTest.testDeleteConnector`
    * `RebalanceSourceConnectorsIntegrationTest.testStartTwoConnectors`
    
    **This should be backported to the `2.3` branch, which is when these integration tests were first added.**
    
    Author: Randall Hauch <rh...@gmail.com>
    
    Reviewers: Ismael Juma
    
    Closes #7237 from rhauch/kafka-8391-temporary
    
    (cherry picked from commit 5b4e749dc671df583588c713913bb9eb85e67cc2)
    Signed-off-by: Gwen Shapira <gw...@confluent.io>
---
 .../connect/integration/RebalanceSourceConnectorsIntegrationTest.java | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/connect/runtime/src/test/java/org/apache/kafka/connect/integration/RebalanceSourceConnectorsIntegrationTest.java b/connect/runtime/src/test/java/org/apache/kafka/connect/integration/RebalanceSourceConnectorsIntegrationTest.java
index ad93534..d9ff223 100644
--- a/connect/runtime/src/test/java/org/apache/kafka/connect/integration/RebalanceSourceConnectorsIntegrationTest.java
+++ b/connect/runtime/src/test/java/org/apache/kafka/connect/integration/RebalanceSourceConnectorsIntegrationTest.java
@@ -24,6 +24,7 @@ import org.apache.kafka.connect.util.clusters.EmbeddedConnectCluster;
 import org.apache.kafka.test.IntegrationTest;
 import org.junit.After;
 import org.junit.Before;
+import org.junit.Ignore;
 import org.junit.Test;
 import org.junit.experimental.categories.Category;
 import org.slf4j.Logger;
@@ -100,6 +101,7 @@ public class RebalanceSourceConnectorsIntegrationTest {
         connect.stop();
     }
 
+    @Ignore("Flaky and disruptive. See KAFKA-8391, KAFKA-8661 for details.")
     @Test
     public void testStartTwoConnectors() throws Exception {
         // create test topic
@@ -131,6 +133,7 @@ public class RebalanceSourceConnectorsIntegrationTest {
                 CONNECTOR_SETUP_DURATION_MS, "Connector tasks did not start in time.");
     }
 
+    @Ignore("Flaky and disruptive. See KAFKA-8391, KAFKA-8661 for details.")
     @Test
     public void testReconfigConnector() throws Exception {
         ConnectorHandle connectorHandle = RuntimeHandles.get().connectorHandle(CONNECTOR_NAME);
@@ -186,6 +189,7 @@ public class RebalanceSourceConnectorsIntegrationTest {
                 recordNum >= numRecordsProduced);
     }
 
+    @Ignore("Flaky and disruptive. See KAFKA-8391, KAFKA-8661 for details.")
     @Test
     public void testDeleteConnector() throws Exception {
         // create test topic