You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/03/28 00:39:23 UTC
[GitHub] [incubator-yunikorn-k8shim] yangwwei opened a new pull request #91:
[YUNIKORN-63] Handle occupied resources while registering a node.
yangwwei opened a new pull request #91: [YUNIKORN-63] Handle occupied resources while registering a node.
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/91
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-yunikorn-k8shim] wilfred-s closed pull request #91:
[YUNIKORN-63] Handle occupied resources while registering a node.
Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #91: [YUNIKORN-63] Handle occupied resources while registering a node.
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/91
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-yunikorn-k8shim] wilfred-s commented on issue #91:
[YUNIKORN-63] Handle occupied resources while registering a node.
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on issue #91: [YUNIKORN-63] Handle occupied resources while registering a node.
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/91#issuecomment-605630317
See my comment in the jira: why this change from not needing it in apache/incubator-yunikorn-core#108 to needing it now?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-yunikorn-k8shim] yangwwei commented on issue #91:
[YUNIKORN-63] Handle occupied resources while registering a node.
Posted by GitBox <gi...@apache.org>.
yangwwei commented on issue #91: [YUNIKORN-63] Handle occupied resources while registering a node.
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/91#issuecomment-606200513
> See my comment in the jira: why this change from not needing it in apache/incubator-yunikorn-core#108 to needing it now?
This is found while testing the recovery on a real cluster. When it tries to report the occupied resources to the scheduler-core, **the node is not yet registered**. Therefore, the latest patch ensures that when we register the node, we need to have the initial occupied resources counted correctly.
My previous fix (only updating the node capacity) might have the same issue, but I guess I missed that during the local test (not covering the recovery test).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services