You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/06 06:38:43 UTC
[GitHub] [spark] HyukjinKwon opened a new pull request, #37426: [SPARK-39963][SQL][TESTS][FOLLOW-UP] Disable ANSI mode for test of casting date to decimal
HyukjinKwon opened a new pull request, #37426:
URL: https://github.com/apache/spark/pull/37426
### What changes were proposed in this pull request?
This PR is a followup of https://github.com/apache/spark/pull/37389 which disables ANSI mode when testing a case from date to decimal.
### Why are the changes needed?
To make the test pass. Currently it fails with ANSI mode on, see also https://github.com/apache/spark/runs/7701218236?check_suite_focus=true.
### Does this PR introduce _any_ user-facing change?
No, test-only.
### How was this patch tested?
I manually ran the test in my local.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #37426: [SPARK-39963][SQL][TESTS][FOLLOW-UP] Disable ANSI mode for test of casting date to decimal
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on PR #37426:
URL: https://github.com/apache/spark/pull/37426#issuecomment-1207529232
Thanks, merging to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang closed pull request #37426: [SPARK-39963][SQL][TESTS][FOLLOW-UP] Disable ANSI mode for test of casting date to decimal
Posted by GitBox <gi...@apache.org>.
gengliangwang closed pull request #37426: [SPARK-39963][SQL][TESTS][FOLLOW-UP] Disable ANSI mode for test of casting date to decimal
URL: https://github.com/apache/spark/pull/37426
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #37426: [SPARK-39963][SQL][TESTS][FOLLOW-UP] Disable ANSI mode for test of casting date to decimal
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #37426:
URL: https://github.com/apache/spark/pull/37426#issuecomment-1207160522
cc @cloud-fan and @beliefer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org