[GitHub] [iceberg] samredai commented on pull request #3252: Hive: Add tests for HiveCatalog no-arg constructor, setConf, and initialize

[GitBox <gi...@apache.org>]

samredai commented on pull request #3252:
URL: https://github.com/apache/iceberg/pull/3252#issuecomment-939563308


   Ok updated the PR with one more go at it. I cleaned it up to just `warn` when initializing without a config and then using a `new Configuration()` to initialize with. Then there's just 3 tests that check that:
   
   1. Initializing without a config does not raise
   2. `toString` does not raise if ran before `setConf`
   3. Properties passed to `initialize` are properly set even if the user did not `setConf()` explicitly
   
   For `1.` and `2.` I used `assertDoesNotThrow` so the intention is clear (thanks @kbendick )


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org