You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2022/06/22 08:36:34 UTC
[GitHub] [zookeeper] kezhuw opened a new pull request, #1896: ZOOKEEPER-3996: Fix flaky ReadOnlyModeTest.testConnectionEvents
kezhuw opened a new pull request, #1896:
URL: https://github.com/apache/zookeeper/pull/1896
The same watcher was resued across different clients. It is hard to
know which event will last during verification, disconnected from old
client or connected from new client.
A brand new watcher solves this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] kezhuw commented on pull request #1896: ZOOKEEPER-3996: Fix flaky ReadOnlyModeTest.testConnectionEvents
Posted by GitBox <gi...@apache.org>.
kezhuw commented on PR #1896:
URL: https://github.com/apache/zookeeper/pull/1896#issuecomment-1162818578
Failed ci:
* https://github.com/apache/zookeeper/runs/6982815844?check_suite_focus=true
* https://github.com/kezhuw/zookeeper/runs/6996423868?check_suite_focus=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] kezhuw commented on pull request #1896: ZOOKEEPER-3996: Fix flaky ReadOnlyModeTest.testConnectionEvents
Posted by GitBox <gi...@apache.org>.
kezhuw commented on PR #1896:
URL: https://github.com/apache/zookeeper/pull/1896#issuecomment-1162842601
#1667([ZOOKEEPER-4271](https://issues.apache.org/jira/browse/ZOOKEEPER-4271)) proposed another approach. But it have not updated almost a year.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] anmolnar commented on pull request #1896: ZOOKEEPER-3996: Fix flaky ReadOnlyModeTest.testConnectionEvents
Posted by "anmolnar (via GitHub)" <gi...@apache.org>.
anmolnar commented on PR #1896:
URL: https://github.com/apache/zookeeper/pull/1896#issuecomment-1596805095
Submitted and Jira resolved. Thanks @kezhuw !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] kezhuw commented on pull request #1896: ZOOKEEPER-3996: Fix flaky ReadOnlyModeTest.testConnectionEvents
Posted by "kezhuw (via GitHub)" <gi...@apache.org>.
kezhuw commented on PR #1896:
URL: https://github.com/apache/zookeeper/pull/1896#issuecomment-1595646440
The old test could not last 10 runs after adding `Thread.sleep(700)` before `watcher.waitForReadOnlyConnected(5000)`. The assertion message proves that "disconnected from old client" comes after "connected from new client".
After patch with `watcher = new CountdownWatcher()`, the test last 100 runs with no failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] anmolnar merged pull request #1896: ZOOKEEPER-3996: Fix flaky ReadOnlyModeTest.testConnectionEvents
Posted by "anmolnar (via GitHub)" <gi...@apache.org>.
anmolnar merged PR #1896:
URL: https://github.com/apache/zookeeper/pull/1896
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org