[GitHub] [hive] deniskuzZ edited a comment on pull request #2547: HIVE-25346: cleanTxnToWriteIdTable breaks SNAPSHOT isolation

[GitBox <gi...@apache.org>]

deniskuzZ edited a comment on pull request #2547:
URL: https://github.com/apache/hive/pull/2547#issuecomment-916945444


   @zchovan thank you for the benchmarks! 
   Last thing, to be on a safe side, could you please record INSERTS only if min_history is not available + use old logic for writeId removal based on min_history if available. @pvary, what do you think?
   ````
   if (!useMinHistoryLevel && isInsert(stmt, txnid)) {
   ....
   }
   ````


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org