You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by GitBox <gi...@apache.org> on 2019/04/03 17:56:03 UTC

[GitHub] [cxf] reta edited a comment on issue #529: CXF-8009: CXF should not rely on ClassUtils for CGLIB proxy checks

reta edited a comment on issue #529: CXF-8009: CXF should not rely on ClassUtils for CGLIB proxy checks
URL: https://github.com/apache/cxf/pull/529#issuecomment-479593978
 
 
   @rmannibucau Converted `SpringAopClassHelper` to `SpringClassUnwrapper`, so now `ClassHelper` is completely driven by `ClassUnwrapper`s. I had to preserve the default behavior which uses the system properties, I know that people use it (recall multiple discussions around that). 
   
   I introduced 2 new methods to `ClassUnwrapper`: `getRealClassFromClass` and `getRealObject`. I kept the name `getRealClassFromClass` (not the `getClassFromModel` as you suggested) because it looks to me that `ClassUnwrapper` should not really care about underlying model (CDI/Spring), but it could be used to back different models if needed (fe Annotated, BeanDefinition, ...). The `getRealObject` is outlier but really  needed to fully replace the `ClassHelper` functionality (it is a default method, no need to implement).
   
   Regarding  `CompositeClassUnwrapper ` it is absolutely possible now, I didn't introduce it yet since I just don't have use case at this moment. If PR looks good, we could build on top.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services