You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Felix Meschberger (JIRA)" <ji...@apache.org> on 2009/06/12 16:06:07 UTC
[jira] Created: (FELIX-1232) Do not use private configuration
properties as service properties
Do not use private configuration properties as service properties
-----------------------------------------------------------------
Key: FELIX-1232
URL: https://issues.apache.org/jira/browse/FELIX-1232
Project: Felix
Issue Type: New Feature
Components: Declarative Services (SCR), Specification compliance
Affects Versions: scr-1.0.8
Reporter: Felix Meschberger
Fix For: scr-1.2.0
R4.2 of the OSGi compendium spec will introduce the notion of private properties. Private properties are properties whose names have leading dots. Such private properties should not be propagated to service properties.
See also 104.4.3, Property Propagation, in the draft R4.2 Compendium Specification (dated 2009/03/10).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1232) Do not use private configuration
properties as service properties
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737528#action_12737528 ]
Felix Meschberger commented on FELIX-1232:
------------------------------------------
Thanks for providing the patch. I think it may be simplified since we just have a single use case for filtering: private properties with a leading dot.
In addition the getServiceProperties() internally calls copyTo with a null target already thus creating a copy. Therefore the registerService method does have to create another copy.
> Do not use private configuration properties as service properties
> -----------------------------------------------------------------
>
> Key: FELIX-1232
> URL: https://issues.apache.org/jira/browse/FELIX-1232
> Project: Felix
> Issue Type: New Feature
> Components: Declarative Services (SCR), Specification compliance
> Affects Versions: scr-1.0.8
> Reporter: Felix Meschberger
> Assignee: Felix Meschberger
> Fix For: scr-1.2.0
>
> Attachments: FELIX-1232.patch
>
>
> R4.2 of the OSGi compendium spec will introduce the notion of private properties. Private properties are properties whose names have leading dots. Such private properties should not be propagated to service properties.
> See also 104.4.3, Property Propagation, in the draft R4.2 Compendium Specification (dated 2009/03/10).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-1232) Do not use private configuration
properties as service properties
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger updated FELIX-1232:
-------------------------------------
Component/s: (was: Declarative Services (SCR))
> Do not use private configuration properties as service properties
> -----------------------------------------------------------------
>
> Key: FELIX-1232
> URL: https://issues.apache.org/jira/browse/FELIX-1232
> Project: Felix
> Issue Type: New Feature
> Components: Specification compliance
> Affects Versions: scr-1.0.8
> Reporter: Felix Meschberger
> Fix For: scr-1.2.0
>
>
> R4.2 of the OSGi compendium spec will introduce the notion of private properties. Private properties are properties whose names have leading dots. Such private properties should not be propagated to service properties.
> See also 104.4.3, Property Propagation, in the draft R4.2 Compendium Specification (dated 2009/03/10).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1232) Do not use private configuration
properties as service properties
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737533#action_12737533 ]
Felix Meschberger commented on FELIX-1232:
------------------------------------------
Applied a modified patch in Rev. 799618.
I simplified the assumption of privacy being a leading dot and we only have two requirements: all properties or properties whose names have no leading dot. Using a simple boolean "allProps" flag allows for an easy and straight forward implementation.
> Do not use private configuration properties as service properties
> -----------------------------------------------------------------
>
> Key: FELIX-1232
> URL: https://issues.apache.org/jira/browse/FELIX-1232
> Project: Felix
> Issue Type: New Feature
> Components: Declarative Services (SCR), Specification compliance
> Affects Versions: scr-1.0.8
> Reporter: Felix Meschberger
> Assignee: Felix Meschberger
> Fix For: scr-1.2.0
>
> Attachments: FELIX-1232.patch
>
>
> R4.2 of the OSGi compendium spec will introduce the notion of private properties. Private properties are properties whose names have leading dots. Such private properties should not be propagated to service properties.
> See also 104.4.3, Property Propagation, in the draft R4.2 Compendium Specification (dated 2009/03/10).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (FELIX-1232) Do not use private configuration
properties as service properties
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger reassigned FELIX-1232:
----------------------------------------
Assignee: Felix Meschberger
> Do not use private configuration properties as service properties
> -----------------------------------------------------------------
>
> Key: FELIX-1232
> URL: https://issues.apache.org/jira/browse/FELIX-1232
> Project: Felix
> Issue Type: New Feature
> Components: Declarative Services (SCR), Specification compliance
> Affects Versions: scr-1.0.8
> Reporter: Felix Meschberger
> Assignee: Felix Meschberger
> Fix For: scr-1.2.0
>
> Attachments: FELIX-1232.patch
>
>
> R4.2 of the OSGi compendium spec will introduce the notion of private properties. Private properties are properties whose names have leading dots. Such private properties should not be propagated to service properties.
> See also 104.4.3, Property Propagation, in the draft R4.2 Compendium Specification (dated 2009/03/10).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Work started: (FELIX-1232) Do not use private configuration
properties as service properties
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on FELIX-1232 started by Felix Meschberger.
> Do not use private configuration properties as service properties
> -----------------------------------------------------------------
>
> Key: FELIX-1232
> URL: https://issues.apache.org/jira/browse/FELIX-1232
> Project: Felix
> Issue Type: New Feature
> Components: Declarative Services (SCR), Specification compliance
> Affects Versions: scr-1.0.8
> Reporter: Felix Meschberger
> Assignee: Felix Meschberger
> Fix For: scr-1.2.0
>
> Attachments: FELIX-1232.patch
>
>
> R4.2 of the OSGi compendium spec will introduce the notion of private properties. Private properties are properties whose names have leading dots. Such private properties should not be propagated to service properties.
> See also 104.4.3, Property Propagation, in the draft R4.2 Compendium Specification (dated 2009/03/10).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-1232) Do not use private configuration
properties as service properties
Posted by "Alin Dreghiciu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alin Dreghiciu updated FELIX-1232:
----------------------------------
Attachment: FELIX-1232.patch
A simple patch that will filter properties to be used while registering the service.
The filtering could have been done in the registration but the approach in the patch looks to me more meaningful.
> Do not use private configuration properties as service properties
> -----------------------------------------------------------------
>
> Key: FELIX-1232
> URL: https://issues.apache.org/jira/browse/FELIX-1232
> Project: Felix
> Issue Type: New Feature
> Components: Declarative Services (SCR), Specification compliance
> Affects Versions: scr-1.0.8
> Reporter: Felix Meschberger
> Fix For: scr-1.2.0
>
> Attachments: FELIX-1232.patch
>
>
> R4.2 of the OSGi compendium spec will introduce the notion of private properties. Private properties are properties whose names have leading dots. Such private properties should not be propagated to service properties.
> See also 104.4.3, Property Propagation, in the draft R4.2 Compendium Specification (dated 2009/03/10).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (FELIX-1232) Do not use private configuration
properties as service properties
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger resolved FELIX-1232.
--------------------------------------
Resolution: Fixed
Added an integration test ensuring the private component property is visible to the component but not to service clients in Rev. 799625.
This should do this issue and I consider it resolved.
> Do not use private configuration properties as service properties
> -----------------------------------------------------------------
>
> Key: FELIX-1232
> URL: https://issues.apache.org/jira/browse/FELIX-1232
> Project: Felix
> Issue Type: New Feature
> Components: Declarative Services (SCR), Specification compliance
> Affects Versions: scr-1.0.8
> Reporter: Felix Meschberger
> Assignee: Felix Meschberger
> Fix For: scr-1.2.0
>
> Attachments: FELIX-1232.patch
>
>
> R4.2 of the OSGi compendium spec will introduce the notion of private properties. Private properties are properties whose names have leading dots. Such private properties should not be propagated to service properties.
> See also 104.4.3, Property Propagation, in the draft R4.2 Compendium Specification (dated 2009/03/10).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-1232) Do not use private configuration
properties as service properties
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger updated FELIX-1232:
-------------------------------------
Component/s: Declarative Services (SCR)
> Do not use private configuration properties as service properties
> -----------------------------------------------------------------
>
> Key: FELIX-1232
> URL: https://issues.apache.org/jira/browse/FELIX-1232
> Project: Felix
> Issue Type: New Feature
> Components: Declarative Services (SCR), Specification compliance
> Affects Versions: scr-1.0.8
> Reporter: Felix Meschberger
> Fix For: scr-1.2.0
>
>
> R4.2 of the OSGi compendium spec will introduce the notion of private properties. Private properties are properties whose names have leading dots. Such private properties should not be propagated to service properties.
> See also 104.4.3, Property Propagation, in the draft R4.2 Compendium Specification (dated 2009/03/10).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (FELIX-1232) Do not use private configuration
properties as service properties
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger closed FELIX-1232.
------------------------------------
SCR 1.2.0 has been released. Close all issues.
> Do not use private configuration properties as service properties
> -----------------------------------------------------------------
>
> Key: FELIX-1232
> URL: https://issues.apache.org/jira/browse/FELIX-1232
> Project: Felix
> Issue Type: New Feature
> Components: Declarative Services (SCR), Specification compliance
> Affects Versions: scr-1.0.8
> Reporter: Felix Meschberger
> Assignee: Felix Meschberger
> Fix For: scr-1.2.0
>
> Attachments: FELIX-1232.patch
>
>
> R4.2 of the OSGi compendium spec will introduce the notion of private properties. Private properties are properties whose names have leading dots. Such private properties should not be propagated to service properties.
> See also 104.4.3, Property Propagation, in the draft R4.2 Compendium Specification (dated 2009/03/10).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.