[GitHub] [rocketmq-clients] lizhanhui commented on a diff in pull request #542: Allow user to disable TLS in cpp.

["lizhanhui (via GitHub)" <gi...@apache.org>]

lizhanhui commented on code in PR #542:
URL: https://github.com/apache/rocketmq-clients/pull/542#discussion_r1226447897


##########
cpp/source/rocketmq/include/ClientImpl.h:
##########
@@ -94,6 +94,10 @@ class ClientImpl : virtual public Client {
     client_config_.request_timeout = absl::FromChrono(request_timeout);
   }
 
+  void withEnableSsl(bool enable) {

Review Comment:
   withEnableSsl sounds weird.
   Rename it to `withTls` or `withSsl`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org