[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #2566: arch/risc-v: Add BL602 support

[GitBox <gi...@apache.org>]

davids5 commented on a change in pull request #2566:
URL: https://github.com/apache/incubator-nuttx/pull/2566#discussion_r616836971



##########
File path: include/nuttx/arch.h
##########
@@ -1353,6 +1354,39 @@ void up_irqinitialize(void);
 
 bool up_interrupt_context(void);
 
+/****************************************************************************
+ * Name: up_irq_save
+ *
+ * Description:
+ *   Save the current interrupt state and disable interrupts.
+ *
+ * Input Parameters:
+ *   None
+ *
+ * Returned Value:
+ *   Interrupt state prior to disabling interrupts.
+ *
+ ****************************************************************************/
+
+irqstate_t up_irq_save(void);
+
+/****************************************************************************
+ * Name: up_irq_restore
+ *
+ * Description:
+ *   Restore the previous irq state (i.e., the one previously
+ *   returned by up_irq_save())
+ *
+ * Input Parameters:
+ *   irqstate - The interrupt state to be restored.
+ *
+ * Returned Value:
+ *   None
+ *
+ ****************************************************************************/
+
+void up_irq_restore(irqstate_t irqstate);
+

Review comment:
       @btashton @v01d Building against 10.1 the irq.h defines `up_irq_restore` and `up_irq_save` as inlines, but these definition are not
   ```
   nuttx/include/nuttx/arch.h:1386:12: error: conflicting declaration of 'irqstate_t up_irq_save()' with 'C' linkage
    1386 | irqstate_t up_irq_save(void);
         |            ^~~~~~~~~~~
   ```
   
   Should this not have come in?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org