You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/12/22 07:15:55 UTC

[GitHub] [pulsar] michaeljmarshall opened a new pull request, #19026: [fix][proxy] Update clientAuthData in ProxyConnection as needed

michaeljmarshall opened a new pull request, #19026:
URL: https://github.com/apache/pulsar/pull/19026

   Master Issue: #10816
   
   ### Motivation
   
   In issue #10816, we see that a new lookup command triggers auth failure. In reading through the solution from #17831, I noticed that we are still open to a specific kind of failure. Specifically, the auth data for a client is stored indefinitely in the proxy. As a result, when the proxy attempts to make a new connection to a broker for a lookup, then the auth data may be expired.
   
   ### Modifications
   
   * Update the `clientAuthData` when the client sends it. This solution does not cover the case where the data is still out of date, so I may look at finding a better solution.
   
   ### Verifying this change
   
   I will work on a test for this change.
   
   ### Does this pull request potentially affect one of the following parts:
   
   This solution restores expected functionality for the ability to refresh authentication data seamlessly when using the proxy.
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `sh start.sh` at `pulsar/site2/website`) to your PR description, or else your PR might not get merged. -->
   - [x] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   
   ### Matching PR in forked repository
   
   PR in forked repository: https://github.com/michaeljmarshall/pulsar/pull/9
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #19026: [fix][proxy] Update clientAuthData in ProxyConnection as needed

Posted by github-actions.
github-actions[bot] commented on PR #19026:
URL: https://github.com/apache/pulsar/pull/19026#issuecomment-1399384599

   The pr had no activity for 30 days, mark with Stale label.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] poorbarcode commented on pull request #19026: [fix][proxy] Update clientAuthData in ProxyConnection as needed

Posted by "poorbarcode (via GitHub)" <gi...@apache.org>.
poorbarcode commented on PR #19026:
URL: https://github.com/apache/pulsar/pull/19026#issuecomment-1501516224

   Since we will start the RC version of `3.0.0` on `2023-04-11`, I will change the label/milestone of PR who have not been merged.
   - The PR of type `feature` is deferred to `3.1.0`
   - The PR of type `fix` is deferred to `3.0.1`
   
   So drag this PR to `3.0.1`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] michaeljmarshall closed pull request #19026: [fix][proxy] Update clientAuthData in ProxyConnection as needed

Posted by "michaeljmarshall (via GitHub)" <gi...@apache.org>.
michaeljmarshall closed pull request #19026: [fix][proxy] Update clientAuthData in ProxyConnection as needed
URL: https://github.com/apache/pulsar/pull/19026


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #19026: [fix][proxy] Update clientAuthData in ProxyConnection as needed

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19026:
URL: https://github.com/apache/pulsar/pull/19026#issuecomment-1543179131

   The pr had no activity for 30 days, mark with Stale label.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] michaeljmarshall commented on pull request #19026: [fix][proxy] Update clientAuthData in ProxyConnection as needed

Posted by "michaeljmarshall (via GitHub)" <gi...@apache.org>.
michaeljmarshall commented on PR #19026:
URL: https://github.com/apache/pulsar/pull/19026#issuecomment-1543351202

   Superseded by https://github.com/apache/pulsar/pull/20067.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org