[jira] Commented: (DERBY-1962) Convert jdbcapi/resultsetJdbc30.java to junit

["Knut Anders Hatlen (JIRA)" <de...@db.apache.org>]

    [ http://issues.apache.org/jira/browse/DERBY-1962?page=comments#action_12442815 ] 
            
Knut Anders Hatlen commented on DERBY-1962:
-------------------------------------------

I think the patch looks good, but it seems the preferred way to make an embedded-only suite has changed to

  public static Test suite() {
    return TestConfiguration.embeddedSuite(ResultSetJDBC30Test.class);
  }

Minor nits (not important to fix, only suggestions on how to reduce the amount of code in case you plan to convert more tests to JUnit):
  - I think fail(...) is clearer than assertTrue(..., false)
  - it is not necessary to retrieve the connection object so often since BaseJDBCTestCase has helper methods like createStatement(), prepareStatement() and commit().

> Convert jdbcapi/resultsetJdbc30.java to junit
> ---------------------------------------------
>
>                 Key: DERBY-1962
>                 URL: http://issues.apache.org/jira/browse/DERBY-1962
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Test
>            Reporter: Fernanda Pizzorno
>         Assigned To: Fernanda Pizzorno
>         Attachments: derby-1962.diff, derby-1962.stat
>
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira