You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flex.apache.org by Erik de Bruin <er...@ixsoftware.nl> on 2013/01/17 12:41:58 UTC
[FalconJx] 'remove' string literals from emitter class code
Mike, just to let you know: I'm working on replacing all strings in
the emitter(s) to use a constant or enum. So you might want to stay
clear of the emitter classes this morning ;-)
EdB
--
Ix Multimedia Software
Jan Luykenstraat 27
3521 VB Utrecht
T. 06-51952295
I. www.ixsoftware.nl
Re: [FalconJx] 'remove' string literals from emitter class code
Posted by Michael Schmalle <ap...@teotigraphix.com>.
Erik,
I reread what wrote below and it didn't come out the way I meant it
to, what I really meant to say is "I was thinking about doing what you
did with the newlines already, since you changed it, I didn't have to
decide". :)
BTW, Those constants are probably going to end up in either an Enum or
Interface. Stuff like that can be shared and we don't want concrete
class references with static constants.
Mike
Quoting Michael Schmalle <ap...@teotigraphix.com>:
>
> Quoting Erik de Bruin <er...@ixsoftware.nl>:
>
>> Ok, I'm done... took a bit longer than expected, interesting task,
>> still getting to know the code :-)
>
> Yeah, you changed the newlines algorithm, I was debating what you
> did but, since you got all the tests to pass I guess I will accept
> the change. :) I wrote the method write() to be carriage/indent
> return when it found a newline but your abstraction and forcing the
> newLine() call works.
>
> What part of the code don't you understand?
>
> BTW, I was the one that put the ugly constant in there, don't forget that.
>
> Mike
>
>> EdB
>>
>>
>>
>> On Thu, Jan 17, 2013 at 12:46 PM, Michael Schmalle
>> <ap...@teotigraphix.com> wrote:
>>>
>>> Quoting Erik de Bruin <er...@ixsoftware.nl>:
>>>
>>>> Mike, just to let you know: I'm working on replacing all strings in
>>>> the emitter(s) to use a constant or enum. So you might want to stay
>>>> clear of the emitter classes this morning ;-)
>>>
>>>
>>> Ok, I have two driveways to clear snow from this morning, so that
>>> won't be a
>>> problem. :)
>>>
>>> Side note; Do you think we really need the emitEnd*() method anymore? Seems
>>> like that issue is cleared up, if you don't need it, remove it.
>>>
>>> Mike
>>>
>>>
>>>
>>>> EdB
>>>>
>>>>
>>>>
>>>> --
>>>> Ix Multimedia Software
>>>>
>>>> Jan Luykenstraat 27
>>>> 3521 VB Utrecht
>>>>
>>>> T. 06-51952295
>>>> I. www.ixsoftware.nl
>>>>
>>>
>>> --
>>> Michael Schmalle - Teoti Graphix, LLC
>>> http://www.teotigraphix.com
>>> http://blog.teotigraphix.com
>>>
>>
>>
>>
>> --
>> Ix Multimedia Software
>>
>> Jan Luykenstraat 27
>> 3521 VB Utrecht
>>
>> T. 06-51952295
>> I. www.ixsoftware.nl
>>
>
> --
> Michael Schmalle - Teoti Graphix, LLC
> http://www.teotigraphix.com
> http://blog.teotigraphix.com
>
>
--
Michael Schmalle - Teoti Graphix, LLC
http://www.teotigraphix.com
http://blog.teotigraphix.com
Re: [FalconJx] 'remove' string literals from emitter class code
Posted by Michael Schmalle <ap...@teotigraphix.com>.
Quoting Erik de Bruin <er...@ixsoftware.nl>:
> Ok, I'm done... took a bit longer than expected, interesting task,
> still getting to know the code :-)
Yeah, you changed the newlines algorithm, I was debating what you did
but, since you got all the tests to pass I guess I will accept the
change. :) I wrote the method write() to be carriage/indent return
when it found a newline but your abstraction and forcing the newLine()
call works.
What part of the code don't you understand?
BTW, I was the one that put the ugly constant in there, don't forget that.
Mike
> EdB
>
>
>
> On Thu, Jan 17, 2013 at 12:46 PM, Michael Schmalle
> <ap...@teotigraphix.com> wrote:
>>
>> Quoting Erik de Bruin <er...@ixsoftware.nl>:
>>
>>> Mike, just to let you know: I'm working on replacing all strings in
>>> the emitter(s) to use a constant or enum. So you might want to stay
>>> clear of the emitter classes this morning ;-)
>>
>>
>> Ok, I have two driveways to clear snow from this morning, so that won't be a
>> problem. :)
>>
>> Side note; Do you think we really need the emitEnd*() method anymore? Seems
>> like that issue is cleared up, if you don't need it, remove it.
>>
>> Mike
>>
>>
>>
>>> EdB
>>>
>>>
>>>
>>> --
>>> Ix Multimedia Software
>>>
>>> Jan Luykenstraat 27
>>> 3521 VB Utrecht
>>>
>>> T. 06-51952295
>>> I. www.ixsoftware.nl
>>>
>>
>> --
>> Michael Schmalle - Teoti Graphix, LLC
>> http://www.teotigraphix.com
>> http://blog.teotigraphix.com
>>
>
>
>
> --
> Ix Multimedia Software
>
> Jan Luykenstraat 27
> 3521 VB Utrecht
>
> T. 06-51952295
> I. www.ixsoftware.nl
>
--
Michael Schmalle - Teoti Graphix, LLC
http://www.teotigraphix.com
http://blog.teotigraphix.com
Re: [FalconJx] 'remove' string literals from emitter class code
Posted by Erik de Bruin <er...@ixsoftware.nl>.
Ok, I'm done... took a bit longer than expected, interesting task,
still getting to know the code :-)
EdB
On Thu, Jan 17, 2013 at 12:46 PM, Michael Schmalle
<ap...@teotigraphix.com> wrote:
>
> Quoting Erik de Bruin <er...@ixsoftware.nl>:
>
>> Mike, just to let you know: I'm working on replacing all strings in
>> the emitter(s) to use a constant or enum. So you might want to stay
>> clear of the emitter classes this morning ;-)
>
>
> Ok, I have two driveways to clear snow from this morning, so that won't be a
> problem. :)
>
> Side note; Do you think we really need the emitEnd*() method anymore? Seems
> like that issue is cleared up, if you don't need it, remove it.
>
> Mike
>
>
>
>> EdB
>>
>>
>>
>> --
>> Ix Multimedia Software
>>
>> Jan Luykenstraat 27
>> 3521 VB Utrecht
>>
>> T. 06-51952295
>> I. www.ixsoftware.nl
>>
>
> --
> Michael Schmalle - Teoti Graphix, LLC
> http://www.teotigraphix.com
> http://blog.teotigraphix.com
>
--
Ix Multimedia Software
Jan Luykenstraat 27
3521 VB Utrecht
T. 06-51952295
I. www.ixsoftware.nl
Re: [FalconJx] 'remove' string literals from emitter class code
Posted by Michael Schmalle <ap...@teotigraphix.com>.
Quoting Erik de Bruin <er...@ixsoftware.nl>:
> Mike, just to let you know: I'm working on replacing all strings in
> the emitter(s) to use a constant or enum. So you might want to stay
> clear of the emitter classes this morning ;-)
Ok, I have two driveways to clear snow from this morning, so that
won't be a problem. :)
Side note; Do you think we really need the emitEnd*() method anymore?
Seems like that issue is cleared up, if you don't need it, remove it.
Mike
> EdB
>
>
>
> --
> Ix Multimedia Software
>
> Jan Luykenstraat 27
> 3521 VB Utrecht
>
> T. 06-51952295
> I. www.ixsoftware.nl
>
--
Michael Schmalle - Teoti Graphix, LLC
http://www.teotigraphix.com
http://blog.teotigraphix.com