You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Steve Carlin (Code Review)" <ge...@cloudera.org> on 2021/12/18 15:23:35 UTC

[Impala-ASF-CR] IMPALA-11062: "now string" option not working properly

Steve Carlin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18108


Change subject: IMPALA-11062: "now_string" option not working properly
......................................................................

IMPALA-11062: "now_string" option not working properly

The "now_string" option was not working when queries are
being sent through the "ExecutePlannedStatement" API. The
string needed to be copied over to the TQueryCtx object
used in RuntimeState.

Change-Id: I977b3a53553aaa40f8d82e7b5b6883b1a6a23065
---
M be/src/runtime/query-driver.cc
1 file changed, 2 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/18108/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18108
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I977b3a53553aaa40f8d82e7b5b6883b1a6a23065
Gerrit-Change-Number: 18108
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>

[Impala-ASF-CR] IMPALA-11062: "now string" option not working properly

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18108 )

Change subject: IMPALA-11062: "now_string" option not working properly
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7711/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/18108
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I977b3a53553aaa40f8d82e7b5b6883b1a6a23065
Gerrit-Change-Number: 18108
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 18 Dec 2021 18:47:56 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11062: "now string" option not working properly

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18108 )

Change subject: IMPALA-11062: "now_string" option not working properly
......................................................................


Patch Set 2:

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7758/


-- 
To view, visit http://gerrit.cloudera.org:8080/18108
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I977b3a53553aaa40f8d82e7b5b6883b1a6a23065
Gerrit-Change-Number: 18108
Gerrit-PatchSet: 2
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Comment-Date: Tue, 25 Jan 2022 04:58:11 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11062: "now string" option not working properly

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18108 )

Change subject: IMPALA-11062: "now_string" option not working properly
......................................................................


Patch Set 2: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7755/


-- 
To view, visit http://gerrit.cloudera.org:8080/18108
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I977b3a53553aaa40f8d82e7b5b6883b1a6a23065
Gerrit-Change-Number: 18108
Gerrit-PatchSet: 2
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Comment-Date: Mon, 24 Jan 2022 21:29:32 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11062: "now string" option not working properly

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18108 )

Change subject: IMPALA-11062: "now_string" option not working properly
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7755/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/18108
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I977b3a53553aaa40f8d82e7b5b6883b1a6a23065
Gerrit-Change-Number: 18108
Gerrit-PatchSet: 2
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Comment-Date: Mon, 24 Jan 2022 15:02:56 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11062: "now string" option not working properly

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18108 )

Change subject: IMPALA-11062: "now_string" option not working properly
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7760/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/18108
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I977b3a53553aaa40f8d82e7b5b6883b1a6a23065
Gerrit-Change-Number: 18108
Gerrit-PatchSet: 2
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Comment-Date: Tue, 25 Jan 2022 05:26:28 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11062: "now string" option not working properly

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18108 )

Change subject: IMPALA-11062: "now_string" option not working properly
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18108
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I977b3a53553aaa40f8d82e7b5b6883b1a6a23065
Gerrit-Change-Number: 18108
Gerrit-PatchSet: 2
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Comment-Date: Tue, 25 Jan 2022 12:01:37 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11062: "now string" option not working properly

Posted by "Kurt Deschler (Code Review)" <ge...@cloudera.org>.
Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/18108 )

Change subject: IMPALA-11062: "now_string" option not working properly
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18108
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I977b3a53553aaa40f8d82e7b5b6883b1a6a23065
Gerrit-Change-Number: 18108
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Comment-Date: Mon, 24 Jan 2022 14:36:33 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11062: "now string" option not working properly

Posted by "Aman Sinha (Code Review)" <ge...@cloudera.org>.
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/18108 )

Change subject: IMPALA-11062: "now_string" option not working properly
......................................................................


Patch Set 2: Code-Review+2

Carry forward Kurt's +1 and bumping to +2


-- 
To view, visit http://gerrit.cloudera.org:8080/18108
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I977b3a53553aaa40f8d82e7b5b6883b1a6a23065
Gerrit-Change-Number: 18108
Gerrit-PatchSet: 2
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Comment-Date: Tue, 25 Jan 2022 22:35:18 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11062: "now string" option not working properly

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18108 )

Change subject: IMPALA-11062: "now_string" option not working properly
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18108
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I977b3a53553aaa40f8d82e7b5b6883b1a6a23065
Gerrit-Change-Number: 18108
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 19 Dec 2021 01:04:14 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11062: "now string" option not working properly

Posted by "Aman Sinha (Code Review)" <ge...@cloudera.org>.
Aman Sinha has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18108 )

Change subject: IMPALA-11062: "now_string" option not working properly
......................................................................

IMPALA-11062: "now_string" option not working properly

The "now_string" option was not working when queries are
being sent through the "ExecutePlannedStatement" API. The
string needed to be copied over to the TQueryCtx object
used in RuntimeState.

Change-Id: I977b3a53553aaa40f8d82e7b5b6883b1a6a23065
Reviewed-on: http://gerrit.cloudera.org:8080/18108
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Aman Sinha <am...@cloudera.com>
---
M be/src/runtime/query-driver.cc
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Aman Sinha: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/18108
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I977b3a53553aaa40f8d82e7b5b6883b1a6a23065
Gerrit-Change-Number: 18108
Gerrit-PatchSet: 3
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>

[Impala-ASF-CR] IMPALA-11062: "now string" option not working properly

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18108 )

Change subject: IMPALA-11062: "now_string" option not working properly
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7758/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/18108
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I977b3a53553aaa40f8d82e7b5b6883b1a6a23065
Gerrit-Change-Number: 18108
Gerrit-PatchSet: 2
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Comment-Date: Mon, 24 Jan 2022 22:20:55 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11062: "now string" option not working properly

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18108 )

Change subject: IMPALA-11062: "now_string" option not working properly
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/9947/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18108
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I977b3a53553aaa40f8d82e7b5b6883b1a6a23065
Gerrit-Change-Number: 18108
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 18 Dec 2021 15:45:22 +0000
Gerrit-HasComments: No