[jira] [Updated] (LUCENE-7384) Remove ScoringWrapperSpans

["David Smiley (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/LUCENE-7384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Smiley updated LUCENE-7384:
---------------------------------
    Attachment: LUCENE_7384.patch

It's actually used within both SpanNot & SpanOr getSpans()... but of course this wrapper effectively does nothing.  In the attached patch I remove this useless class as well as remove uses of it.  Tests pass.

Since it does nothing (which is itself misleading if anyone actually is using it) and it seems obscure, I propose not keeping it with deprecation in 6x.

Proposed message:

In API Changes: 
* ScoringWrapperSpans was removed since it has no purpose or effect as of Lucene 5.5.

In other:
* LUCENE-7384: Removed ScoringWrapperSpans. And tweaked SpanWeight.buildSimWeight to reuse the existing similarity instead of creating a new one. (David Smiley)

> Remove ScoringWrapperSpans
> --------------------------
>
>                 Key: LUCENE-7384
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7384
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/search
>            Reporter: David Smiley
>         Attachments: LUCENE_7384.patch
>
>
> In LUCENE-6919 (Lucene 5.5), ScoringWrapperSpans was modified in such a way that made the existence of this class pointless, and possibly broke anyone who was using it as it's SimScorer argument isn't used anymore.  We should now delete it.  SpanWeight has getSimScorer() so people can customize the SimScorer that way.
> Another small change I observe to improve is have SpanWeight.buildSimWeight's last line use the existing Similarity that has already been populated on the field?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org