You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2022/04/14 13:59:07 UTC

[GitHub] [geode-native] mmartell opened a new pull request, #959: GEODE-10237: Remove no-ack from testThinClientTransactionsWithSticky

mmartell opened a new pull request, #959:
URL: https://github.com/apache/geode-native/pull/959

   This removes the no-ack functionality from this test, which fails regularly in the CI. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [geode-native] mmartell commented on pull request #959: GEODE-10237: Remove no-ack from testThinClientTransactionsWithSticky

Posted by GitBox <gi...@apache.org>.
mmartell commented on PR #959:
URL: https://github.com/apache/geode-native/pull/959#issuecomment-1115397563

   > This is, IMO, too much code to duplicate, and adding the new file rather than editing the existing one really obscures the nature of this change. Please try just editing `ThinClientTrasactions.hpp` and resubmit.
   
   Good catch Blake! Not sure why I thought I needed to use a new header file. As you point out, just needed to refactor the original header.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org