You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2022/06/01 21:23:47 UTC

[GitHub] [helix] NealSun96 commented on a diff in pull request #2120: Fix failing ZkClient TTL test

NealSun96 commented on code in PR #2120:
URL: https://github.com/apache/helix/pull/2120#discussion_r887314448


##########
helix-core/src/test/java/org/apache/helix/manager/zk/TestZkBaseDataAccessor.java:
##########
@@ -239,7 +239,6 @@ public void testSyncCreateWithTTL() {
     Assert.assertNotNull(getRecord);
     Assert.assertEquals(getRecord.getSimpleFields().size(), 0);
 
-    System.clearProperty("zookeeper.extendedTypesEnabled");

Review Comment:
   Synced offline



##########
zookeeper-api/src/test/java/org/apache/helix/zookeeper/impl/client/TestRawZkClient.java:
##########
@@ -146,7 +123,6 @@ void testCreatePersistentWithTTL() {
     // Clean up
     zkClient.deleteRecursively(parentPath);
     zkClient.close();
-    System.clearProperty("zookeeper.extendedTypesEnabled");
   }
 
   @Test

Review Comment:
   Synced offline. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org