[GitHub] [spark] HeartSaVioR commented on a change in pull request #26994: [SPARK-30339][SQL] Avoid to fail twice in function lookup

[GitBox <gi...@apache.org>]

HeartSaVioR commented on a change in pull request #26994: [SPARK-30339][SQL] Avoid to fail twice in function lookup
URL: https://github.com/apache/spark/pull/26994#discussion_r361846764
 
 

 ##########
 File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala
 ##########
 @@ -117,12 +117,25 @@ private[sql] class HiveSessionCatalog(
     try {
       lookupFunction0(name, children)
     } catch {
-      case NonFatal(_) =>
 
 Review comment:
   > But we still need to append another case NonFatal(e) below to make sure that exception will be threw finally for the function without any DecimalType children.
   
   Could you please elaborate? If I'm not missing anything, the exception doesn't match any cases, exception will be propagated to caller.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org