[GitHub] xiaohanyu commented on a change in pull request #5966: Improve development experience with Docker

[GitBox <gi...@apache.org>]

xiaohanyu commented on a change in pull request #5966: Improve development experience with Docker
URL: https://github.com/apache/incubator-superset/pull/5966#discussion_r223769142
 
 

 ##########
 File path: contrib/docker/docker-compose.yml
 ##########
 @@ -29,20 +31,22 @@ services:
       POSTGRES_PORT: 5432
       REDIS_HOST: redis
       REDIS_PORT: 6379
-      SUPERSET_ENV: local
+      # If using production, comment development volume below
+      SUPERSET_ENV: development
     ports:
       - 8088:8088
-    command: "tail -f /dev/null"
     depends_on:
       - postgres
       - redis
     volumes:
-      - .:/home/work/incubator-superset
-      - superset-node-modules:/home/work/incubator-superset/superset/assets/node_modules
+      # this is needed to communicate with the postgres and redis services
+      - ./superset_config.py:/home/work/incubator-superset/superset/superset_config.py
+      # this is needed for development, remove with SUPERSET_ENV=production
+      - ../../superset:/home/work/incubator-superset/superset
 volumes:
   postgres:
     external: false
   redis:
     external: false
-  superset-node-modules:
+  frontend-dist:
 
 Review comment:
   So after you rename to `frontend-dist`, where's `frontend-dist` volume? it will be empty?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org